[
https://issues.apache.org/jira/browse/DISPATCH-960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17163660#comment-17163660
]
ASF GitHub Bot commented on DISPATCH-960:
-----------------------------------------
jiridanek edited a comment on pull request #294:
URL: https://github.com/apache/qpid-dispatch/pull/294#issuecomment-663054639
@gemmellr It already does what it is supposed to do, so I thought it is
ready to be merged. The improvement is there, macOS travis job is allowed to
fail, and the behavior on invalid protocol name is not any worse than it was
before.
I did not close the Jira because I was planning to revisit the issue
regarding my comments, either myself when there is the c_unittests pr merged,
which should be soon now, or see if @fgiorgetti maybe fixes it in the meantime.
edit: if what I've done is questionable, which I acknowledge it probably is,
I'll learn for the future. Anyways, i wouldn't've spotted the macOS failure
until I rebased and merged the PR, because the PR is older than the macOS job
in Travis.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> TCP port randomly assigned when using 'port: amqp' along with 'http: yes' on
> a listener
> ---------------------------------------------------------------------------------------
>
> Key: DISPATCH-960
> URL: https://issues.apache.org/jira/browse/DISPATCH-960
> Project: Qpid Dispatch
> Issue Type: Bug
> Affects Versions: 1.0.1, 1.12.0
> Reporter: Fernando Giorgetti
> Priority: Major
> Fix For: 1.13.0
>
> Attachments: dispatch-960-reproducer.tar.gz
>
>
> The default configuration for the dispatch router contains a default listener
> set up to use 'port: amqp'.
> If you change the default listener to use 'http: yes' and starts the router,
> it causes an issue as the service name (amqp) is not resolved, and so the
> router attempts to listen to port 0 (random), causing an unpredictable
> behavior.
>
> A reproducer is attached to this issue.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
