[ 
https://issues.apache.org/jira/browse/DISPATCH-1727?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17166464#comment-17166464
 ] 

Jiri Daněk edited comment on DISPATCH-1727 at 7/28/20, 2:30 PM:
----------------------------------------------------------------

Do you intend to keep yarn.lock in the repository? That would mean keeping two 
files which essentially overlap/duplicate each other. I was originally thinking 
of picking one or the other, not both...


was (Author: jdanek):
Do you intend to keep yarn.lock in place? That would mean keeping two files 
which essentially overlap/duplicate each other. I was originally thinking of 
picking one or the other, not both...

> Dispatch Console mixes usage of `npm` with `yarn`
> -------------------------------------------------
>
>                 Key: DISPATCH-1727
>                 URL: https://issues.apache.org/jira/browse/DISPATCH-1727
>             Project: Qpid Dispatch
>          Issue Type: Bug
>          Components: Console
>    Affects Versions: 1.12.0
>            Reporter: Jiri Daněk
>            Assignee: Ernest Allen
>            Priority: Critical
>             Fix For: 2.0.0
>
>
> There is a `yarn.lock` file checked into the repository, but CMake build file 
> is using straight `npm` to build the console.
> This means that the content of `yarn.lock` is used during Console development 
> (if yarn is used to build and test the console) and it is ignored when CMake 
> is building Dispatch Console for deployment.
> There is a package locking mechanism in npm since npm version 5. It is 
> `package-lock.json`. We should decide if we want to use yarn or npm, and use 
> the corresponding command in CMake, and use the correct lock file.
> The decision should take into account users of Dispatch, who may not have 
> access to npm 5, possibly. I am not sure if this is relevant consideration.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to