[
https://issues.apache.org/jira/browse/DISPATCH-1733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17169057#comment-17169057
]
ASF GitHub Bot commented on DISPATCH-1733:
------------------------------------------
ganeshmurthy commented on a change in pull request #803:
URL: https://github.com/apache/qpid-dispatch/pull/803#discussion_r463758935
##########
File path: src/router_core/connections.c
##########
@@ -1381,6 +1381,10 @@ static void qdr_connection_opened_CT(qdr_core_t *core,
qdr_action_t *action, boo
qdrc_event_conn_raise(core, QDRC_EVENT_CONN_OPENED, conn);
}
+ if (discard && conn) {
Review comment:
Thanks @kgiusti I have added code to check conn and discard at the top
of the functions like other action routines and also dropped a level of
indentation. The diff looks weird because of dropping one level of indentation
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> system_tests_open_properties failure due to qdr_connection_t leak
> -----------------------------------------------------------------
>
> Key: DISPATCH-1733
> URL: https://issues.apache.org/jira/browse/DISPATCH-1733
> Project: Qpid Dispatch
> Issue Type: Bug
> Components: Tests
> Reporter: Ganesh Murthy
> Priority: Major
> Labels: Leak
>
> {noformat}
> 67: ======================================================================
> 67: ERROR: test_01_verify_listener_properties
> (system_tests_open_properties.OpenPropertiesConfigTest)
> 67: ----------------------------------------------------------------------
> 67: Traceback (most recent call last):
> 67: File
> "/home/travis/build/apache/qpid-dispatch/tests/system_tests_open_properties.py",
> line 197, in test_01_verify_listener_properties
> 67: self._valid_properties_check(OpenPropertiesClient)
> 67: File
> "/home/travis/build/apache/qpid-dispatch/tests/system_tests_open_properties.py",
> line 194, in _valid_properties_check
> 67: router.teardown()
> 67: File "/home/travis/build/apache/qpid-dispatch/tests/system_test.py",
> line 538, in teardown
> 67: raise teardown_exc
> 67: RuntimeError: Process 14125 error: exit code -6, expected 0
> 67: qdrouterd -c Router2.conf -I
> /home/travis/build/apache/qpid-dispatch/python
> 67:
> /home/travis/build/apache/qpid-dispatch/build/tests/system_test.dir/system_tests_open_properties/OpenPropertiesConfigTest/test_01_verify_listener_properties/Router2-15.cmd
> 67: >>>>
> 67: ERROR: Aborted due to unexpected alloc pool leak of type
> 'qdr_connection_t'
> 67: <<<<
> 67: alloc.c: Items of type 'qdr_connection_t' remain allocated at shutdown: 1
> 67: Leak: 2020-07-30 10:22:26.902114 +0000 type: qdr_connection_t address:
> 0x1818e10
> 67:
> /home/travis/build/apache/qpid-dispatch/build/src/libqpid-dispatch.so(qd_alloc+0x842)
> [0x7f09cefafd6c]
> 67:
> /home/travis/build/apache/qpid-dispatch/build/src/libqpid-dispatch.so(new_qdr_connection_t+0x38)
> [0x7f09cf00ad3b]
> 67:
> /home/travis/build/apache/qpid-dispatch/build/src/libqpid-dispatch.so(qdr_connection_opened+0x79)
> [0x7f09cf00b19a]
> 67:
> /home/travis/build/apache/qpid-dispatch/build/src/libqpid-dispatch.so(+0x1026d4)
> [0x7f09cf0626d4]
> 67:
> /home/travis/build/apache/qpid-dispatch/build/src/libqpid-dispatch.so(+0x103557)
> [0x7f09cf063557]
> 67:
> /home/travis/build/apache/qpid-dispatch/build/src/libqpid-dispatch.so(+0x5ecee)
> [0x7f09cefbecee]
> 67:
> /home/travis/build/apache/qpid-dispatch/build/src/libqpid-dispatch.so(policy_notify_opened+0x3d)
> [0x7f09cefbedfd]
> 67:
> /home/travis/build/apache/qpid-dispatch/build/src/libqpid-dispatch.so(qd_policy_amqp_open+0x67f)
> [0x7f09cefea388]
> 67:
> /home/travis/build/apache/qpid-dispatch/build/src/libqpid-dispatch.so(qd_container_handle_event+0x117)
> [0x7f09cefbfea6]
> 67:
> /home/travis/build/apache/qpid-dispatch/build/src/libqpid-dispatch.so(+0x10efa0)
> [0x7f09cf06efa0]{noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
