[ 
https://issues.apache.org/jira/browse/DISPATCH-1737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17169164#comment-17169164
 ] 

ASF GitHub Bot commented on DISPATCH-1737:
------------------------------------------

ChugR opened a new pull request #808:
URL: https://github.com/apache/qpid-dispatch/pull/808


   When config file json parsing fails then the parser prints a line and
   column number of the offending input. Since the original input is modified
   by the config process the reported line and column numbers are not useful.
   
   This patch logs the input that json was given when parsing fails.
   The parser failure line and column numbers directly relate to logged
   json input lines and syntax errors may be identifed with some authority.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


> Policy config parse errors report wrong line and column numbers 
> ----------------------------------------------------------------
>
>                 Key: DISPATCH-1737
>                 URL: https://issues.apache.org/jira/browse/DISPATCH-1737
>             Project: Qpid Dispatch
>          Issue Type: Bug
>          Components: Management Agent
>    Affects Versions: 1.12.0
>            Reporter: Charles E. Rolke
>            Assignee: Charles E. Rolke
>            Priority: Major
>
> Config files may be written in _router config_ format or _json_ format. 
> Either way the file data is reorganized internally into _json_ format. After 
> the data is reorganized then the original text formatting is lost. If there 
> is a json parse error then the json errors showing line and column numbers 
> are for the reformatted text and can not be correlated to the original input.
> This issue adds error logs in the event of a config parse error. The logs 
> show the config data as it was presented to the json parser. Users may then 
> see specifically where the config parsing failed with respect to their 
> original input.
> This issue is different from DISPATCH-1707. Fixing this issue will aid in 
> debugging and fixing that issue.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to