[
https://issues.apache.org/jira/browse/DISPATCH-1762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17189702#comment-17189702
]
ASF GitHub Bot commented on DISPATCH-1762:
------------------------------------------
ganeshmurthy commented on a change in pull request #843:
URL: https://github.com/apache/qpid-dispatch/pull/843#discussion_r482440099
##########
File path: src/server.c
##########
@@ -1219,6 +1222,8 @@ static void setup_ssl_sasl_and_open(qd_connection_t *ctx)
qd_log(ct->server->log_source, QD_LOG_ERROR,
"SSL local configuration failed for %s:%s",
config->host, config->port);
+ pn_ssl_domain_free(domain);
+ return;
Review comment:
could we populate a boolean inside these if statements and check it
finally and then return ? That would keep the code behaving as it was earlier.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Setting verifyHostname to false on connector means certificate is not
> verified at all
> -------------------------------------------------------------------------------------
>
> Key: DISPATCH-1762
> URL: https://issues.apache.org/jira/browse/DISPATCH-1762
> Project: Qpid Dispatch
> Issue Type: Bug
> Reporter: Gordon Sim
> Priority: Major
>
> You can connect even of the CA path specified does not exist. (Expectation
> from the configuration option name is that only the hostname verification is
> disabled, but that the validity of the certificate is still verified).
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
