[
https://issues.apache.org/jira/browse/DISPATCH-1765?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robbie Gemmell updated DISPATCH-1765:
-------------------------------------
Description:
Change to using connection-capabilities for advertisement and detection of the
streaming-links support added in DISPATCH-1545.
Note that this change means the feature will not activate between a 1.14.0+
router and earlier 1.13.0 routers as the former did not advertise the
capability. Few should encounter this given 1.14.0 follows soon behind 1.13.0
and essentially replaces it.
= Original Description =
The version string advertised by the router in the Open performative may be
parsed incorrectly if a non-semantic format is used (e.g. a git commit sha).
Currently the router uses the router version of its peer in order to determine
if the peer supports certain features like streaming links.
Two changes proposed to solve this:
1) do not attempt to parse the version string arriving in the Open
performative. Treat it as opaque ascii data.
2) Add router-defined capabilities and advertise them in the
offered-capabilities field of the Open performative.
was:
The version string advertised by the router in the Open performative may be
parsed incorrectly if a non-semantic format is used (e.g. a git commit sha).
Currently the router uses the router version of its peer in order to determine
if the peer supports certain features like streaming links.
Two changes proposed to solve this:
1) do not attempt to parse the version string arriving in the Open
performative. Treat it as opaque ascii data.
2) Add router-defined capabilities and advertise them in the
offered-capabilities field of the Open performative.
Summary: use connection-capabilities for streaming-links support
detection (was: Router version parsing is broken)
> use connection-capabilities for streaming-links support detection
> -----------------------------------------------------------------
>
> Key: DISPATCH-1765
> URL: https://issues.apache.org/jira/browse/DISPATCH-1765
> Project: Qpid Dispatch
> Issue Type: Bug
> Affects Versions: 1.13.0
> Reporter: Ken Giusti
> Assignee: Ken Giusti
> Priority: Major
> Fix For: 1.14.0
>
>
> Change to using connection-capabilities for advertisement and detection of
> the streaming-links support added in DISPATCH-1545.
> Note that this change means the feature will not activate between a 1.14.0+
> router and earlier 1.13.0 routers as the former did not advertise the
> capability. Few should encounter this given 1.14.0 follows soon behind 1.13.0
> and essentially replaces it.
>
> = Original Description =
> The version string advertised by the router in the Open performative may be
> parsed incorrectly if a non-semantic format is used (e.g. a git commit sha).
> Currently the router uses the router version of its peer in order to
> determine if the peer supports certain features like streaming links.
> Two changes proposed to solve this:
> 1) do not attempt to parse the version string arriving in the Open
> performative. Treat it as opaque ascii data.
> 2) Add router-defined capabilities and advertise them in the
> offered-capabilities field of the Open performative.
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
