[
https://issues.apache.org/jira/browse/QPID-8472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17209257#comment-17209257
]
ASF GitHub Bot commented on QPID-8472:
--------------------------------------
alex-rufous commented on a change in pull request #63:
URL: https://github.com/apache/qpid-broker-j/pull/63#discussion_r500679615
##########
File path:
broker-core/src/main/java/org/apache/qpid/server/queue/AbstractQueue.java
##########
@@ -3520,23 +3521,46 @@ public MessageEnqueueRecord getEnqueueRecord()
destination,
parseSelector(selector),
limit);
- _virtualHost.executeTransaction(transaction);
+ executeTransactionAndLogResults("copyMessages", destination.getName(),
transaction);
return transaction.getModifiedMessageIds();
}
+ private void executeTransactionAndLogResults(final String msg,
Review comment:
The parameter name 'msg' needs to be changed to operationName
Let's move transaction parameter to a second position
the destinationName can be renamed into a targetDestinationName
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> [Broker-J] Improve operational logging for queue operations copying, moving
> and deleting messages
> -------------------------------------------------------------------------------------------------
>
> Key: QPID-8472
> URL: https://issues.apache.org/jira/browse/QPID-8472
> Project: Qpid
> Issue Type: Improvement
> Components: Broker-J
> Reporter: Alex Rudyy
> Priority: Major
> Fix For: qpid-java-broker-8.0.2, qpid-java-broker-7.1.10
>
>
> An operation logging for queue message management operations (copyMessages,
> moveMessages, deleteMessages, clearQueue) need to report a name of source
> queue , a target queue name (if applicable), a number of copied/moved/deleted
> messages and operation status.
> The operational logs could be formatted as below
> {noformat}
> <operation name> : <source queue name> : <target queue name> : <number of
> message> : <status>
> {noformat}
> For example,
> {noformat}
> copy messages : foo : bar : 100
> {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
