[
https://issues.apache.org/jira/browse/PROTON-2170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17215255#comment-17215255
]
ASF GitHub Bot commented on PROTON-2170:
----------------------------------------
jiridanek commented on pull request #271:
URL: https://github.com/apache/qpid-proton/pull/271#issuecomment-709900061
With this patch, `-DBUILD_TESTING=OFF` is to have implicit effects in
CTests, that is, `enable_testing()` is not called, and all `add_test` calls in
CMake become noops. (This is because we now don't call `enable_testing()`
ourselves and rely on CTest to call it when `BUILD_TESTING=ON`, which is the
default.)
Futhermore, when `BUILD_TESTING=OFF`, compilation of test targets is
skipped. This is the main goal of this patch.
There is a possible alternative implementation; conditionally set the
`EXCLUDE_FROM_ALL` property on the test targets,
https://cmake.org/cmake/help/v3.14/prop_tgt/EXCLUDE_FROM_ALL.html, instead of
conditionally skipping part of the CMake file with `if`. This is something I
did not try.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> cmake -DBUILD_TESTING=OFF does not disable building all tests
> -------------------------------------------------------------
>
> Key: PROTON-2170
> URL: https://issues.apache.org/jira/browse/PROTON-2170
> Project: Qpid Proton
> Issue Type: Bug
> Components: build
> Affects Versions: proton-c-0.30.0
> Reporter: Jiri Daněk
> Priority: Major
> Attachments: 0001-CMakeLists.txt-allow-the-user-to-disable-tests.patch
>
>
> Compile as in PROTON-2145, that means
> {noformat}
> mkdir _build
> cd _build
> cmake .. -DCMAKE_INSTALL_PREFIX=/usr/local\
> -DSYSINSTALL_BINDINGS=ON\
> -DBUILD_STATIC_LIBS=ON\
> -DBUILD_TESTING=OFF\
> -DENABLE_FUZZ_TESTING=OFF\
> -DFUZZ_REGRESSION_TESTS=OFF
> make -j4
> make install
> {noformat}
> (leave out -DBUILD_WITH_CXX=ON)
> Despite {{-DBUILD_TESTING=OFF}}, the following is being built
> {noformat}
> [ 42%] Built target test_main
> [ 45%] Built target c-core-test
> [ 45%] Built target c-extra-test
> [ 46%] Built target c-ssl-proactor-test
> [ 47%] Built target c-proactor-test
> [ 65%] Built target interop_test
> [ 65%] Built target credit_test
> [ 65%] Built target reconnect_test
> [ 66%] Built target codec_test
> [ 67%] Built target value_test
> [ 68%] Built target connection_driver_test
> [ 84%] Built target scalar_test
> [ 85%] Built target message_test
> [ 85%] Built target link_test
> [ 86%] Built target container_test
> [ 87%] Built target cpp-test
> [ 88%] Built target map_test
> {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
