[
https://issues.apache.org/jira/browse/PROTON-1496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17217494#comment-17217494
]
ASF GitHub Bot commented on PROTON-1496:
----------------------------------------
codecov-io commented on pull request #275:
URL: https://github.com/apache/qpid-proton/pull/275#issuecomment-712754081
# [Codecov](https://codecov.io/gh/apache/qpid-proton/pull/275?src=pr&el=h1)
Report
> Merging
[#275](https://codecov.io/gh/apache/qpid-proton/pull/275?src=pr&el=desc) into
[master](https://codecov.io/gh/apache/qpid-proton/commit/34ca28fae4a880151440c33312ca7f723441c2b2?el=desc)
will **decrease** coverage by `0.20%`.
> The diff coverage is `34.82%`.
[](https://codecov.io/gh/apache/qpid-proton/pull/275?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #275 +/- ##
==========================================
- Coverage 79.68% 79.48% -0.21%
==========================================
Files 342 343 +1
Lines 42886 42989 +103
==========================================
- Hits 34175 34170 -5
- Misses 8711 8819 +108
```
| [Impacted
Files](https://codecov.io/gh/apache/qpid-proton/pull/275?src=pr&el=tree) |
Coverage Δ | |
|---|---|---|
|
[c/src/proactor/epoll-internal.h](https://codecov.io/gh/apache/qpid-proton/pull/275/diff?src=pr&el=tree#diff-Yy9zcmMvcHJvYWN0b3IvZXBvbGwtaW50ZXJuYWwuaA==)
| `86.66% <ø> (ø)` | |
|
[c/src/proactor/epoll\_timer\_queue.c](https://codecov.io/gh/apache/qpid-proton/pull/275/diff?src=pr&el=tree#diff-Yy9zcmMvcHJvYWN0b3IvZXBvbGxfdGltZXJfcXVldWUuYw==)
| `27.67% <27.67%> (ø)` | |
|
[c/src/proactor/epoll.c](https://codecov.io/gh/apache/qpid-proton/pull/275/diff?src=pr&el=tree#diff-Yy9zcmMvcHJvYWN0b3IvZXBvbGwuYw==)
| `81.97% <61.90%> (-0.24%)` | :arrow_down: |
|
[c/src/ssl/openssl.c](https://codecov.io/gh/apache/qpid-proton/pull/275/diff?src=pr&el=tree#diff-Yy9zcmMvc3NsL29wZW5zc2wuYw==)
| `83.28% <0.00%> (-0.11%)` | :arrow_down: |
|
[c/tests/threaderciser.c](https://codecov.io/gh/apache/qpid-proton/pull/275/diff?src=pr&el=tree#diff-Yy90ZXN0cy90aHJlYWRlcmNpc2VyLmM=)
| `83.73% <0.00%> (+0.05%)` | :arrow_up: |
|
[c/src/core/codec.c](https://codecov.io/gh/apache/qpid-proton/pull/275/diff?src=pr&el=tree#diff-Yy9zcmMvY29yZS9jb2RlYy5j)
| `82.43% <0.00%> (+0.13%)` | :arrow_up: |
------
[Continue to review full report at
Codecov](https://codecov.io/gh/apache/qpid-proton/pull/275?src=pr&el=continue).
> **Legend** - [Click here to learn
more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by
[Codecov](https://codecov.io/gh/apache/qpid-proton/pull/275?src=pr&el=footer).
Last update
[34ca28f...c15d749](https://codecov.io/gh/apache/qpid-proton/pull/275?src=pr&el=lastupdated).
Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> C epoll proactor needs better timer implementation for connections
> ------------------------------------------------------------------
>
> Key: PROTON-1496
> URL: https://issues.apache.org/jira/browse/PROTON-1496
> Project: Qpid Proton
> Issue Type: Improvement
> Components: proton-c
> Affects Versions: proton-c-0.18.0
> Environment: Linux environments with epoll support
> Reporter: Clifford Jansen
> Assignee: Clifford Jansen
> Priority: Major
>
> The epoll proactor allocates a timerfd per connection. This is a convenience
> for the initial implementation and may surprise some applications running
> into system limits on file descriptors twice as fast as expected.
> The timer is used for heartbeats. It should be possible to write a
> per-proactor heartbeat timer that is shared among the connections
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
