[
https://issues.apache.org/jira/browse/DISPATCH-1767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17219467#comment-17219467
]
ASF subversion and git services commented on DISPATCH-1767:
-----------------------------------------------------------
Commit 1f07dc28e02a0275839747a7b0516dbc80368f64 in qpid-dispatch's branch
refs/heads/dependabot/npm_and_yarn/console/react/patternfly/patternfly-4.50.4
from Jiri Daněk
[ https://gitbox.apache.org/repos/asf?p=qpid-dispatch.git;h=1f07dc2 ]
DISPATCH-1767 Add typescript to console dependencies (#887)
Typescript is required to run eslint.
> [console] add typescript to console dependencies
> ------------------------------------------------
>
> Key: DISPATCH-1767
> URL: https://issues.apache.org/jira/browse/DISPATCH-1767
> Project: Qpid Dispatch
> Issue Type: Improvement
> Components: Console
> Affects Versions: 1.13.0
> Reporter: Jiri Daněk
> Priority: Trivial
> Fix For: 1.15.0
>
>
> {{npm install}} reports a warning
> {noformat}
> npm WARN [email protected] requires a peer of typescript@>=2.8.0 || >= 3.2.0-dev
> || >= 3.3.0-dev || >= 3.4.0-dev || >= 3.5.0-dev || >= 3.6.0-dev || >=
> 3.6.0-beta || >= 3.7.0-dev || >= 3.7.0-beta but none is installed. You must
> install peer dependencies yourself.
> {noformat}
> This is relevant because {{eslint}} will not run without typescript. The
> GitHub Action has to install typescript in a subsequent step.
> Adding typescript would also allow to write production code and/or tests in
> typescript, which has some advantages. The Patternfly project seems
> especially to be very Typescript focused, recently. The Rhea AMQP client also
> added typescript type annotations.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
