[
https://issues.apache.org/jira/browse/DISPATCH-1814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17221408#comment-17221408
]
ASF GitHub Bot commented on DISPATCH-1814:
------------------------------------------
jiridanek commented on pull request #895:
URL: https://github.com/apache/qpid-dispatch/pull/895#issuecomment-717228696
I read through the diff and it looks ok. In the future, it might be
reasonable to let the tool go through all whitespace changes in one go;
autopep8 should be trustworthy enough to simply do that.
There is one problem with merging these changes now; the feature branch for
http2 support. Having these formatting changes on master would make it harder
to merge that branch later.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Apply autofixes to resolve some flake8 code formatting issues
> -------------------------------------------------------------
>
> Key: DISPATCH-1814
> URL: https://issues.apache.org/jira/browse/DISPATCH-1814
> Project: Qpid Dispatch
> Issue Type: Task
> Affects Versions: 1.14.0
> Reporter: Jiri Daněk
> Assignee: Jiri Daněk
> Priority: Trivial
>
> The general strategy for dealing with these in a scalable manner could be as
> follows
> Identify warning we want to resolve, e.g. E701 multiple statements on a
> single line.
> Remove E701 from flake8 ignore list in {{tests/tox.ini.in}}.
> Run the autofixer
> {code}
> pip install autoflake8
> for f in `find -name "*.py"`; do autopep8 --in-place --select=E701 $f; done
> for f in `find tests -name "*.py.in"`; do autopep8 --in-place --select=E701
> $f; done
> autopep8 --in-place --select=E701 tools/*.in
> {code}
> Wait about two minutes.
> Review the diffs produced.
> Submit a change request.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
