[ 
https://issues.apache.org/jira/browse/DISPATCH-1780?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17226856#comment-17226856
 ] 

ASF GitHub Bot commented on DISPATCH-1780:
------------------------------------------

grs commented on a change in pull request #909:
URL: https://github.com/apache/qpid-dispatch/pull/909#discussion_r518216671



##########
File path: src/adaptors/http1/http1_server.c
##########
@@ -1056,11 +1063,10 @@ void 
qdr_http1_server_core_link_flow(qdr_http1_adaptor_t    *adaptor,
                 rmsg->dlv = qdr_link_deliver_to(hconn->in_link, rmsg->msg, 0, 
addr, false, 0, 0, 0, 0);
                 qdr_delivery_set_context(rmsg->dlv, (void*) hreq);
                 rmsg->msg = 0;
-                if (!rmsg->rx_complete) {
+                if (!rmsg->rx_complete || hconn->cfg.aggregation != 
QD_AGGREGATION_NONE) {
                     // stop here since response must be complete before we can 
deliver the next one.

Review comment:
       Will update comment. I don't want to free the response until it is 
accepted.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> multicast support for http 1.1 adaptor
> --------------------------------------
>
>                 Key: DISPATCH-1780
>                 URL: https://issues.apache.org/jira/browse/DISPATCH-1780
>             Project: Qpid Dispatch
>          Issue Type: Improvement
>            Reporter: Gordon Sim
>            Assignee: Gordon Sim
>            Priority: Major
>             Fix For: 1.15.0
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

Reply via email to