[
https://issues.apache.org/jira/browse/PROTON-2295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17230536#comment-17230536
]
ASF GitHub Bot commented on PROTON-2295:
----------------------------------------
gemmellr commented on pull request #276:
URL: https://github.com/apache/qpid-proton/pull/276#issuecomment-726018835
Great. Seems to have worked.
Stylistic nit, I think Its nicer if the if is the first element of a step,
it makes it easier to discern if the step is relevant or not when reading the
config...admittedly it is clear from the output/status details for the job that
a given step has run or not though.
Could perhaps also rename the step to "Setup go (Mac OS)" to distinguish it?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> [go] Go 1.15.3 failure in macOS CI; panic: can't call pointer on a
> non-pointer Value
> ------------------------------------------------------------------------------------
>
> Key: PROTON-2295
> URL: https://issues.apache.org/jira/browse/PROTON-2295
> Project: Qpid Proton
> Issue Type: Bug
> Components: go-binding
> Reporter: Jiri Daněk
> Assignee: Jiri Daněk
> Priority: Major
> Fix For: proton-c-0.33.0
>
>
> https://github.com/apache/qpid-proton/runs/1360866596#step:13:2474
> {noformat}
> 28: goroutine 9 [running]:
> 28: reflect.Value.pointer(...)
> 28: /usr/local/Cellar/go/1.15.3/libexec/src/reflect/value.go:95
> 28: reflect.Value.Pointer(0x4165a00, 0x4f054b0, 0x16, 0xb)
> 28: /usr/local/Cellar/go/1.15.3/libexec/src/reflect/value.go:1456 +0x1b6
> 28: fmt.(*pp).fmtPointer(0xc0000731e0, 0x4165a00, 0x4f054b0, 0x16, 0x70)
> 28: /usr/local/Cellar/go/1.15.3/libexec/src/fmt/print.go:506 +0x65
> 28: fmt.(*pp).printArg(0xc0000731e0, 0x4165a00, 0x4f054b0, 0xc000000070)
> 28: /usr/local/Cellar/go/1.15.3/libexec/src/fmt/print.go:659 +0x168
> 28: fmt.(*pp).doPrintf(0xc0000731e0, 0x41a591c, 0xd, 0xc000223df0, 0x1, 0x1)
> 28: /usr/local/Cellar/go/1.15.3/libexec/src/fmt/print.go:1030 +0x168
> 28: fmt.Sprintf(0x41a591c, 0xd, 0xc000223df0, 0x1, 0x1, 0x4f054b0, 0x0)
> 28: /usr/local/Cellar/go/1.15.3/libexec/src/fmt/print.go:219 +0x66
> 28: github.com/apache/qpid-proton/go/pkg/proton.Session.String(...)
> 28:
> /Users/runner/work/qpid-proton/qpid-proton/BLD/go/pkg/proton/wrappers.go:369
> 28: github.com/apache/qpid-proton/go/pkg/electron.newSession(0xc00011a000,
> 0x4f054b0, 0x0, 0x0, 0x0, 0xc000223f00)
> 28:
> /Users/runner/work/qpid-proton/qpid-proton/BLD/go/pkg/electron/session.go:64
> +0xac
> 28:
> github.com/apache/qpid-proton/go/pkg/electron.(*connection).Session.func1(0x2,
> 0x2)
> 28:
> /Users/runner/work/qpid-proton/qpid-proton/BLD/go/pkg/electron/connection.go:272
> +0x1bf
> 28: github.com/apache/qpid-proton/go/pkg/proton.(*Engine).InjectWait.func1()
> 28:
> /Users/runner/work/qpid-proton/qpid-proton/BLD/go/pkg/proton/engine.go:208
> +0x32
> 28: github.com/apache/qpid-proton/go/pkg/proton.(*Engine).Run(0xc00010a120,
> 0x0, 0x0)
> 28:
> /Users/runner/work/qpid-proton/qpid-proton/BLD/go/pkg/proton/engine.go:376
> +0x19a
> 28:
> github.com/apache/qpid-proton/go/pkg/electron.(*connection).run(0xc00011a000)
> 28:
> /Users/runner/work/qpid-proton/qpid-proton/BLD/go/pkg/electron/connection.go:241
> +0x3f
> 28: created by github.com/apache/qpid-proton/go/pkg/electron.NewConnection
> 28:
> /Users/runner/work/qpid-proton/qpid-proton/BLD/go/pkg/electron/connection.go:224
> +0x405
> 28: panic: can't call pointer on a non-pointer Value
> {noformat}
> This appears to be a bug in Go 1.15.3; versions 1.15.2 and 1.15.4 do not
> exhibit this failure. https://github.com/golang/go/issues/42032
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
