[
https://issues.apache.org/jira/browse/DISPATCH-1867?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17246523#comment-17246523
]
ASF GitHub Bot commented on DISPATCH-1867:
------------------------------------------
fgiorgetti commented on a change in pull request #937:
URL: https://github.com/apache/qpid-dispatch/pull/937#discussion_r539293542
##########
File path: src/adaptors/http2/http2_adaptor.c
##########
@@ -2482,49 +2505,56 @@ static void qdr_http2_adaptor_final(void
*adaptor_context)
*/
static void qdr_http2_adaptor_init(qdr_core_t *core, void **adaptor_context)
{
- qdr_http2_adaptor_t *adaptor = NEW(qdr_http2_adaptor_t);
- adaptor->core = core;
- adaptor->adaptor = qdr_protocol_adaptor(core,
- "http2", // name
- adaptor, // context
- qdr_http_activate,
- qdr_http_first_attach,
- qdr_http_second_attach,
- qdr_http_detach,
- qdr_http_flow,
- qdr_http_offer,
- qdr_http_drained,
- qdr_http_drain,
- qdr_http_push,
- qdr_http_deliver,
- qdr_http_get_credit,
- qdr_http_delivery_update,
- qdr_http_conn_close,
- qdr_http_conn_trace);
- adaptor->log_source = qd_log_source(QD_HTTP_LOG_SOURCE);
- adaptor->protocol_log_source = qd_log_source("PROTOCOL");
- adaptor->lock = sys_mutex();
- *adaptor_context = adaptor;
- DEQ_INIT(adaptor->listeners);
- DEQ_INIT(adaptor->connectors);
- DEQ_INIT(adaptor->connections);
+ sys_mutex_lock(core->adaptor_startup_lock);
Review comment:
@ganeshmurthy this is going to cause a deadlock right?
This PR is not causing that crash, but it is hanging during router
initialization.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Router is crashing at startup on RHEL 8
> ----------------------------------------
>
> Key: DISPATCH-1867
> URL: https://issues.apache.org/jira/browse/DISPATCH-1867
> Project: Qpid Dispatch
> Issue Type: Bug
> Affects Versions: 2.0.0
> Reporter: Fernando Giorgetti
> Priority: Major
> Attachments: qdrouterd.conf, rhel8-router.log
>
>
> I have built qpid-dispatch on a RHEL 8 machine but when I try to run it,
> using the attached configuration file, it is causing a segmentation fault.
> Logs have been attached as well.
> Here are the related libraries and dependencies installed on my machine:
>
>
> {code:java}
> → yum list installed libwebsockets* libnghttp2* gcc* qpid*
> Updating Subscription Management repositories.
> Installed Packages
> gcc.x86_64
> 8.3.1-5.1.el8
> @pulp-appstream
>
> gcc-c++.x86_64
> 8.3.1-5.1.el8
> @pulp-appstream
>
> libnghttp2.x86_64
> 1.33.0-3.el8_2.1
> @pulp-baseos
>
> libnghttp2-devel.x86_64
> 1.33.0-3.el8_2.1
>
> @codeready-builder-for-rhel-8-x86_64-rpms
> libwebsockets.x86_64
> 2.4.2-2.el8
> @errata-2019-43333-8
>
> libwebsockets-devel.x86_64
> 2.4.2-2.el8
> @errata-2019-43333-8
>
> qpid-proton-c.x86_64
> 0.33.0-3.el8
> @errata-2020-66078-8
>
> qpid-proton-c-devel.x86_64
> 0.33.0-3.el8
> @errata-2020-66078-8
>
> {code}
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
