[
https://issues.apache.org/jira/browse/DISPATCH-1886?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17250430#comment-17250430
]
ASF GitHub Bot commented on DISPATCH-1886:
------------------------------------------
ganeshmurthy commented on pull request #960:
URL: https://github.com/apache/qpid-dispatch/pull/960#issuecomment-746575563
This looks good to me. Every call to qd_server_activate(conn); must be
protected by the server->conn_activation_lock.
1. The call to qd_server_activate in CORE_connection_activate() (in
router_node.c) is already protected by this lock.
2. This PR removes qd_link_activate()
3. This PR introduces the lock around qd_server_activate call in
qd_connection_invoke_deferred (in server.c)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Review and fix races between connection activation and closure
> --------------------------------------------------------------
>
> Key: DISPATCH-1886
> URL: https://issues.apache.org/jira/browse/DISPATCH-1886
> Project: Qpid Dispatch
> Issue Type: Bug
> Components: Container
> Reporter: Ted Ross
> Assignee: Ted Ross
> Priority: Major
> Fix For: 1.15.0
>
>
> [~cliffjansen] reviewed the usage of connection-wake (activation) in the
> router code and identified some potential issues with the multi-threading
> that occurs between activation and IO processing.
> This Jira will be used to track updates to the code that result from this
> analysis.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
