[
https://issues.apache.org/jira/browse/DISPATCH-1894?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17251242#comment-17251242
]
ASF GitHub Bot commented on DISPATCH-1894:
------------------------------------------
codecov-io commented on pull request #964:
URL: https://github.com/apache/qpid-dispatch/pull/964#issuecomment-747585290
#
[Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/964?src=pr&el=h1)
Report
> Merging
[#964](https://codecov.io/gh/apache/qpid-dispatch/pull/964?src=pr&el=desc)
(5717937) into
[master](https://codecov.io/gh/apache/qpid-dispatch/commit/5593989c3e117d993a1676706aac1875673a0d94?el=desc)
(5593989) will **increase** coverage by `0.02%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/qpid-dispatch/pull/964?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #964 +/- ##
==========================================
+ Coverage 78.84% 78.86% +0.02%
==========================================
Files 110 110
Lines 28375 28384 +9
==========================================
+ Hits 22371 22385 +14
+ Misses 6004 5999 -5
```
| [Impacted
Files](https://codecov.io/gh/apache/qpid-dispatch/pull/964?src=pr&el=tree) |
Coverage Δ | |
|---|---|---|
|
[src/adaptors/http1/http1\_server.c](https://codecov.io/gh/apache/qpid-dispatch/pull/964/diff?src=pr&el=tree#diff-c3JjL2FkYXB0b3JzL2h0dHAxL2h0dHAxX3NlcnZlci5j)
| `84.26% <0.00%> (-0.33%)` | :arrow_down: |
|
[src/iterator.c](https://codecov.io/gh/apache/qpid-dispatch/pull/964/diff?src=pr&el=tree#diff-c3JjL2l0ZXJhdG9yLmM=)
| `89.29% <0.00%> (-0.19%)` | :arrow_down: |
|
[src/router\_core/delivery.c](https://codecov.io/gh/apache/qpid-dispatch/pull/964/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL2RlbGl2ZXJ5LmM=)
| `93.60% <0.00%> (ø)` | |
|
[src/adaptors/http1/http1\_adaptor.c](https://codecov.io/gh/apache/qpid-dispatch/pull/964/diff?src=pr&el=tree#diff-c3JjL2FkYXB0b3JzL2h0dHAxL2h0dHAxX2FkYXB0b3IuYw==)
| `82.72% <0.00%> (+0.05%)` | :arrow_up: |
|
[src/router\_node.c](https://codecov.io/gh/apache/qpid-dispatch/pull/964/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9ub2RlLmM=)
| `93.96% <0.00%> (+0.10%)` | :arrow_up: |
|
[src/adaptors/http\_common.c](https://codecov.io/gh/apache/qpid-dispatch/pull/964/diff?src=pr&el=tree#diff-c3JjL2FkYXB0b3JzL2h0dHBfY29tbW9uLmM=)
| `79.41% <0.00%> (+0.12%)` | :arrow_up: |
|
[src/adaptors/http1/http1\_codec.c](https://codecov.io/gh/apache/qpid-dispatch/pull/964/diff?src=pr&el=tree#diff-c3JjL2FkYXB0b3JzL2h0dHAxL2h0dHAxX2NvZGVjLmM=)
| `85.15% <0.00%> (+0.12%)` | :arrow_up: |
|
[src/router\_core/connections.c](https://codecov.io/gh/apache/qpid-dispatch/pull/964/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL2Nvbm5lY3Rpb25zLmM=)
| `89.42% <0.00%> (+0.20%)` | :arrow_up: |
|
[src/router\_core/transfer.c](https://codecov.io/gh/apache/qpid-dispatch/pull/964/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL3RyYW5zZmVyLmM=)
| `88.86% <0.00%> (+1.11%)` | :arrow_up: |
------
[Continue to review full report at
Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/964?src=pr&el=continue).
> **Legend** - [Click here to learn
more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by
[Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/964?src=pr&el=footer).
Last update
[5593989...5717937](https://codecov.io/gh/apache/qpid-dispatch/pull/964?src=pr&el=lastupdated).
Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Make libnghttp2 library not required
> ------------------------------------
>
> Key: DISPATCH-1894
> URL: https://issues.apache.org/jira/browse/DISPATCH-1894
> Project: Qpid Dispatch
> Issue Type: Bug
> Components: Protocol Adaptors
> Reporter: Ganesh Murthy
> Assignee: Ganesh Murthy
> Priority: Major
>
> Right now the libnghttp2 library is required. Make it optional. If the
> nghttp2 library is not found, the http2 adaptor will not be started and http2
> protocol would be unavailable.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
