[
https://issues.apache.org/jira/browse/DISPATCH-1907?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17260898#comment-17260898
]
ASF GitHub Bot commented on DISPATCH-1907:
------------------------------------------
codecov-io commented on pull request #970:
URL: https://github.com/apache/qpid-dispatch/pull/970#issuecomment-756475515
#
[Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/970?src=pr&el=h1)
Report
> Merging
[#970](https://codecov.io/gh/apache/qpid-dispatch/pull/970?src=pr&el=desc)
(0e952f5) into
[master](https://codecov.io/gh/apache/qpid-dispatch/commit/41139d8c5a68631060029d5e89675aaa42092133?el=desc)
(41139d8) will **increase** coverage by `0.02%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/qpid-dispatch/pull/970?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #970 +/- ##
==========================================
+ Coverage 78.99% 79.01% +0.02%
==========================================
Files 111 111
Lines 28420 28422 +2
==========================================
+ Hits 22450 22458 +8
+ Misses 5970 5964 -6
```
| [Impacted
Files](https://codecov.io/gh/apache/qpid-dispatch/pull/970?src=pr&el=tree) |
Coverage Δ | |
|---|---|---|
|
[src/adaptors/http1/http1\_client.c](https://codecov.io/gh/apache/qpid-dispatch/pull/970/diff?src=pr&el=tree#diff-c3JjL2FkYXB0b3JzL2h0dHAxL2h0dHAxX2NsaWVudC5j)
| `69.94% <ø> (ø)` | |
|
[src/adaptors/http1/http1\_server.c](https://codecov.io/gh/apache/qpid-dispatch/pull/970/diff?src=pr&el=tree#diff-c3JjL2FkYXB0b3JzL2h0dHAxL2h0dHAxX3NlcnZlci5j)
| `85.46% <ø> (ø)` | |
|
[src/adaptors/http2/http2\_adaptor.c](https://codecov.io/gh/apache/qpid-dispatch/pull/970/diff?src=pr&el=tree#diff-c3JjL2FkYXB0b3JzL2h0dHAyL2h0dHAyX2FkYXB0b3IuYw==)
| `2.94% <ø> (ø)` | |
|
[src/adaptors/reference\_adaptor.c](https://codecov.io/gh/apache/qpid-dispatch/pull/970/diff?src=pr&el=tree#diff-c3JjL2FkYXB0b3JzL3JlZmVyZW5jZV9hZGFwdG9yLmM=)
| `0.00% <ø> (ø)` | |
|
[src/adaptors/tcp\_adaptor.c](https://codecov.io/gh/apache/qpid-dispatch/pull/970/diff?src=pr&el=tree#diff-c3JjL2FkYXB0b3JzL3RjcF9hZGFwdG9yLmM=)
| `3.09% <ø> (ø)` | |
|
[src/python\_embedded.c](https://codecov.io/gh/apache/qpid-dispatch/pull/970/diff?src=pr&el=tree#diff-c3JjL3B5dGhvbl9lbWJlZGRlZC5j)
| `68.44% <ø> (ø)` | |
|
[src/router\_core/management\_agent.c](https://codecov.io/gh/apache/qpid-dispatch/pull/970/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL21hbmFnZW1lbnRfYWdlbnQuYw==)
| `97.58% <ø> (ø)` | |
|
[src/policy.c](https://codecov.io/gh/apache/qpid-dispatch/pull/970/diff?src=pr&el=tree#diff-c3JjL3BvbGljeS5j)
| `87.29% <100.00%> (ø)` | |
|
[src/remote\_sasl.c](https://codecov.io/gh/apache/qpid-dispatch/pull/970/diff?src=pr&el=tree#diff-c3JjL3JlbW90ZV9zYXNsLmM=)
| `84.23% <100.00%> (ø)` | |
|
[src/router\_core/agent\_conn\_link\_route.c](https://codecov.io/gh/apache/qpid-dispatch/pull/970/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL2FnZW50X2Nvbm5fbGlua19yb3V0ZS5j)
| `84.21% <100.00%> (+0.09%)` | :arrow_up: |
| ... and [14
more](https://codecov.io/gh/apache/qpid-dispatch/pull/970/diff?src=pr&el=tree-more)
| |
------
[Continue to review full report at
Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/970?src=pr&el=continue).
> **Legend** - [Click here to learn
more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by
[Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/970?src=pr&el=footer).
Last update
[41139d8...0e952f5](https://codecov.io/gh/apache/qpid-dispatch/pull/970?src=pr&el=lastupdated).
Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Make policy enforceable in internal message receivers
> -----------------------------------------------------
>
> Key: DISPATCH-1907
> URL: https://issues.apache.org/jira/browse/DISPATCH-1907
> Project: Qpid Dispatch
> Issue Type: Improvement
> Components: Router Node
> Reporter: Ted Ross
> Assignee: Ted Ross
> Priority: Major
> Fix For: 1.15.0
>
>
> Currently, policy is enforced in the AMQP router-node with a couple of
> cherry-picked policy values being passed into the router-core for enforcement
> there.
> This improvement puts a "policy-spec" structure into the general include path
> which can be accessed anywhere in the router code. Rather than
> cherry-picking values from the policy, a pointer to the policy-spec is passed
> into the core with each opened connection. This structure is available in the
> core and through the core-subscription on_message callback so that handlers
> of internally targeted messages can enforce policy for the endpoint's
> connection.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
