[
https://issues.apache.org/jira/browse/PROTON-2319?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17261535#comment-17261535
]
ASF GitHub Bot commented on PROTON-2319:
----------------------------------------
jiridanek commented on a change in pull request #284:
URL: https://github.com/apache/qpid-proton/pull/284#discussion_r554141239
##########
File path: c/examples/testme
##########
@@ -21,7 +21,7 @@
# Run the C examples and verify that they behave as expected.
# Example executables must be in PATH
-from test_unittest import unittest
Review comment:
This file can still be useful for some Python 2.7 vs 3.6 differences,
such as assertRegex/assertRegexpMatches as used in dispatch
https://github.com/apache/qpid-dispatch/blob/8b91099c6fbbca2e129326e4fcddf5d24a6cd237/tests/system_test.py#L880-L886
I worry that if the file is taken out completely, we may end up adding it
back later (with completely different content, of course).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> [python] Remove support for python 2.6
> --------------------------------------
>
> Key: PROTON-2319
> URL: https://issues.apache.org/jira/browse/PROTON-2319
> Project: Qpid Proton
> Issue Type: Improvement
> Components: python-binding
> Reporter: Andrew Stitcher
> Assignee: Andrew Stitcher
> Priority: Major
>
> Python 2.6 has been on life support for a long time - it's only present in
> Proton because of RHEL 6 which has now gone out of support. So now is a good
> time to remove the remaining awkward bits of code that only exist to support
> Python 2.6.
> Python 2.7 - you're next!
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
