[
https://issues.apache.org/jira/browse/DISPATCH-1911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17263196#comment-17263196
]
ASF GitHub Bot commented on DISPATCH-1911:
------------------------------------------
codecov-io edited a comment on pull request #975:
URL: https://github.com/apache/qpid-dispatch/pull/975#issuecomment-758289880
#
[Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/975?src=pr&el=h1)
Report
> Merging
[#975](https://codecov.io/gh/apache/qpid-dispatch/pull/975?src=pr&el=desc)
(06a77ee) into
[master](https://codecov.io/gh/apache/qpid-dispatch/commit/48bfab2e74a8e18cd50cdacc09876e1d7a0eb250?el=desc)
(48bfab2) will **increase** coverage by `0.00%`.
> The diff coverage is `91.07%`.
[](https://codecov.io/gh/apache/qpid-dispatch/pull/975?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #975 +/- ##
=======================================
Coverage 79.01% 79.02%
=======================================
Files 111 111
Lines 28421 28456 +35
=======================================
+ Hits 22456 22486 +30
- Misses 5965 5970 +5
```
| [Impacted
Files](https://codecov.io/gh/apache/qpid-dispatch/pull/975?src=pr&el=tree) |
Coverage Δ | |
|---|---|---|
|
[src/router\_core/delivery.c](https://codecov.io/gh/apache/qpid-dispatch/pull/975/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL2RlbGl2ZXJ5LmM=)
| `93.42% <0.00%> (-0.19%)` | :arrow_down: |
|
[src/python\_embedded.c](https://codecov.io/gh/apache/qpid-dispatch/pull/975/diff?src=pr&el=tree#diff-c3JjL3B5dGhvbl9lbWJlZGRlZC5j)
| `68.43% <57.14%> (-0.02%)` | :arrow_down: |
|
[src/router\_core/forwarder.c](https://codecov.io/gh/apache/qpid-dispatch/pull/975/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL2ZvcndhcmRlci5j)
| `93.95% <97.67%> (+0.16%)` | :arrow_up: |
|
[src/router\_core/management\_agent.c](https://codecov.io/gh/apache/qpid-dispatch/pull/975/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL21hbmFnZW1lbnRfYWdlbnQuYw==)
| `97.60% <100.00%> (+0.02%)` | :arrow_up: |
|
[src/router\_core/modules/mobile\_sync/mobile.c](https://codecov.io/gh/apache/qpid-dispatch/pull/975/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL21vZHVsZXMvbW9iaWxlX3N5bmMvbW9iaWxlLmM=)
| `92.17% <100.00%> (+0.01%)` | :arrow_up: |
|
[src/router\_core/route\_tables.c](https://codecov.io/gh/apache/qpid-dispatch/pull/975/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL3JvdXRlX3RhYmxlcy5j)
| `80.11% <0.00%> (-0.58%)` | :arrow_down: |
|
[src/adaptors/http1/http1\_server.c](https://codecov.io/gh/apache/qpid-dispatch/pull/975/diff?src=pr&el=tree#diff-c3JjL2FkYXB0b3JzL2h0dHAxL2h0dHAxX3NlcnZlci5j)
| `85.46% <0.00%> (-0.32%)` | :arrow_down: |
|
[src/iterator.c](https://codecov.io/gh/apache/qpid-dispatch/pull/975/diff?src=pr&el=tree#diff-c3JjL2l0ZXJhdG9yLmM=)
| `89.29% <0.00%> (-0.17%)` | :arrow_down: |
|
[src/message.c](https://codecov.io/gh/apache/qpid-dispatch/pull/975/diff?src=pr&el=tree#diff-c3JjL21lc3NhZ2UuYw==)
| `86.72% <0.00%> (ø)` | |
| ... and [2
more](https://codecov.io/gh/apache/qpid-dispatch/pull/975/diff?src=pr&el=tree-more)
| |
------
[Continue to review full report at
Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/975?src=pr&el=continue).
> **Legend** - [Click here to learn
more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by
[Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/975?src=pr&el=footer).
Last update
[48bfab2...06a77ee](https://codecov.io/gh/apache/qpid-dispatch/pull/975?src=pr&el=lastupdated).
Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Allow internal message endpoints using core-subscribe to set terminal
> disposition of received deliveries
> --------------------------------------------------------------------------------------------------------
>
> Key: DISPATCH-1911
> URL: https://issues.apache.org/jira/browse/DISPATCH-1911
> Project: Qpid Dispatch
> Issue Type: Improvement
> Components: Router Node
> Reporter: Ted Ross
> Assignee: Ted Ross
> Priority: Major
> Fix For: 1.15.0
>
>
> Currently, messages delivered to internal components in the router via the
> core/subscribe mechanism have no control over the disposition of received
> deliveries. The deliveries are automatically accepted and settled before
> they are dispatched to the out-of-core handlers, or after an in-core handler
> completes.
> This improvement allows handlers to provide the disposition and an error so
> that messages can be rejected.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
