[
https://issues.apache.org/jira/browse/PROTON-2322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17266101#comment-17266101
]
ASF GitHub Bot commented on PROTON-2322:
----------------------------------------
astitcher commented on a change in pull request #289:
URL: https://github.com/apache/qpid-proton/pull/289#discussion_r558373586
##########
File path: python/proton/_delivery.py
##########
@@ -34,7 +34,7 @@
class NamedInt(int):
- values = {} # type: Dict[int, str]
Review comment:
The doc for mypy says that Dict is available in typing for 2.7 - not
sure what's going on here, but I strongly think we should ignore or silence
flake8 here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Fix and remove ignores in flake8 configuration
> ----------------------------------------------
>
> Key: PROTON-2322
> URL: https://issues.apache.org/jira/browse/PROTON-2322
> Project: Qpid Proton
> Issue Type: Bug
> Components: python-binding
> Affects Versions: proton-c-0.34.0
> Reporter: Jiri Daněk
> Priority: Major
>
> Fixes with autopep8 in PROTON-2320 resolved most of flake8 warnings. There
> are still warnings left that require human consideration and fixing.
> For example, usage of bare {{except}} in the code.
> This must be fixed manually. Fixed issues should then be removed from the
> tox.ini flake8 ignore section.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
