[ 
https://issues.apache.org/jira/browse/DISPATCH-1386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17266826#comment-17266826
 ] 

ASF GitHub Bot commented on DISPATCH-1386:
------------------------------------------

franz1981 edited a comment on pull request #537:
URL: https://github.com/apache/qpid-dispatch/pull/537#issuecomment-761841989


   @kgiusti @ted-ross I see that's sitting here from a long time, but in many 
tests I've performed last year I see this change to be quite beneficial.
   
   Let me summarize the changes:
   
   1. replaced the action list of pointers with a queue of structs (that can 
grow unbounded)
   2. using a wait flag to save some signaling 
   
   It could be improved by using a proper lock-free multi-producer, single 
consumer queue (of structs) or (better) a mesh of single-producer, 
single-consumer queues: some tests from @mgoulish last year on the former 
approach has shown a significant improvement in both latency and throughput by 
using such approach.
   
   This PR is a sort of "half" solution that won't introduce any lock-free 
queue. but is a bit more mechanical friendly with the dispatch allocator.
   
   Let me know your decisision so I can either close or rebase by solving the 
conflicts for this one :+1: 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


> qdr_action_list_t could be replaced by an array of struct q
> -----------------------------------------------------------
>
>                 Key: DISPATCH-1386
>                 URL: https://issues.apache.org/jira/browse/DISPATCH-1386
>             Project: Qpid Dispatch
>          Issue Type: Improvement
>          Components: Routing Engine
>            Reporter: Francesco Nigro
>            Priority: Major
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to