[
https://issues.apache.org/jira/browse/DISPATCH-1912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17267471#comment-17267471
]
ASF GitHub Bot commented on DISPATCH-1912:
------------------------------------------
kgiusti commented on a change in pull request #987:
URL: https://github.com/apache/qpid-dispatch/pull/987#discussion_r559752185
##########
File path: src/router_core/delivery.c
##########
@@ -138,11 +136,16 @@ void qdr_delivery_set_presettled(qdr_delivery_t *delivery)
void qdr_delivery_decref(qdr_core_t *core, qdr_delivery_t *delivery, const
char *label)
{
+ char log_prefix[DLV_ARGS_MAX];
+ if (qd_log_enabled(core->log, QD_LOG_DEBUG)) {
+ snprintf(log_prefix, DLV_ARGS_MAX, DLV_FMT, DLV_ARGS(delivery));
+ }
+
Review comment:
can you set log_prefix to an empty string in an 'else' clause here, just
to keep coverity happy?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Fix TSAN failures in the test suite
> -----------------------------------
>
> Key: DISPATCH-1912
> URL: https://issues.apache.org/jira/browse/DISPATCH-1912
> Project: Qpid Dispatch
> Issue Type: Improvement
> Components: Router Node
> Reporter: Ted Ross
> Assignee: Ted Ross
> Priority: Major
> Fix For: 1.15.0
>
>
> Running the test with the TSAN thread sanitizer on has revealed some issues.
> This Jira will be used for fixes.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
