[
https://issues.apache.org/jira/browse/DISPATCH-1801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17267547#comment-17267547
]
ASF GitHub Bot commented on DISPATCH-1801:
------------------------------------------
kgiusti commented on a change in pull request #988:
URL: https://github.com/apache/qpid-dispatch/pull/988#discussion_r559802170
##########
File path: src/router_core/forwarder.c
##########
@@ -174,8 +173,10 @@ qdr_delivery_t *qdr_forward_new_delivery_CT(qdr_core_t
*core, qdr_delivery_t *in
}
out_dlv->presettled = out_dlv->settled;
- *tag = core->next_tag++;
- out_dlv->tag_length = 8;
+
Review comment:
fix for ASAN unaligned write error, due to the new layout of
qdr_delivery_t!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Link routed outcomes do not propagate all associated state
> ----------------------------------------------------------
>
> Key: DISPATCH-1801
> URL: https://issues.apache.org/jira/browse/DISPATCH-1801
> Project: Qpid Dispatch
> Issue Type: Bug
> Components: Router Node
> Affects Versions: 1.14.0
> Reporter: Ken Giusti
> Assignee: Ken Giusti
> Priority: Major
> Fix For: 1.15.0
>
> Attachments: 0001-link-route-dispo-data-propagation-bugz.patch
>
>
> Delivery outcomes such as REJECTED and MODIFIED allow for extra associated
> data.
> See [Delivery State in AMQP
> 1.0|http://docs.oasis-open.org/amqp/core/v1.0/os/amqp-core-messaging-v1.0-os.html#section-delivery-state]
> For link routes the router must propagate the exact state set by the
> endpoint. In actuality this does not happen:
>
> For MODIFIED, neither the Undeliverable-Here bool nor the extra message
> annotations are propagated across the link. Furthermore it appears that the
> 'failed' boolean is forced to True at some point along the way.
>
> For REJECTED, while both the error name and description ARE propagated, the
> error info is not.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
