[
https://issues.apache.org/jira/browse/DISPATCH-1913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17268092#comment-17268092
]
ASF GitHub Bot commented on DISPATCH-1913:
------------------------------------------
jiridanek commented on a change in pull request #989:
URL: https://github.com/apache/qpid-dispatch/pull/989#discussion_r560376141
##########
File path: tools/qdstat.in
##########
@@ -44,18 +44,17 @@ from qpid_dispatch_internal.compat import UNICODE
def get(obj, attr):
return getattr(obj, attr, None)
-class BusManager(Node):
+class BusManager():
Review comment:
I'm with Ken here.
https://docs.python.org/2.7/glossary.html#term-new-style-class and
https://docs.python.org/2.7/reference/datamodel.html#newstyle state that you
have to inherit from _object_ to get a new-style class. That is true even in
Python 2.7.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> All system tests that run qdstat/qdmanage fail on Ubuntu
> --------------------------------------------------------
>
> Key: DISPATCH-1913
> URL: https://issues.apache.org/jira/browse/DISPATCH-1913
> Project: Qpid Dispatch
> Issue Type: Test
> Components: Tests
> Reporter: Ganesh Murthy
> Assignee: Andrew Stitcher
> Priority: Major
>
> Lots of tests fail in travis with the following error -
> {noformat}
> AttributeError: 'str' object has no attribute 'path' {noformat}
>
> For example,
> {noformat}
> 34:
> ======================================================================34:
> ERROR: test_01_link_route
> (system_tests_two_routers.TwoRouterExtensionStateTest)
> 34: Verify non-terminal state and data propagates over a link route
> 34: ----------------------------------------------------------------------
> 34: Traceback (most recent call last):
> 34: File
> "/home/travis/build/apache/qpid-dispatch/tests/system_tests_two_routers.py",
> line 2034, in test_01_link_route
> 34: self.RouterA.wait_address("RoutieMcRouteFace", remotes=1, count=2)
> 34: File "/home/travis/build/apache/qpid-dispatch/tests/system_test.py",
> line 672, in wait_address
> 34: assert retry(check, **retry_kwargs)
> 34: File "/home/travis/build/apache/qpid-dispatch/tests/system_test.py",
> line 141, in retry
> 34: ret = function()
> 34: File "/home/travis/build/apache/qpid-dispatch/tests/system_test.py",
> line 662, in check
> 34: addrs = self.management.query(
> 34: File "/home/travis/build/apache/qpid-dispatch/tests/system_test.py",
> line 504, in management
> 34: self._management = Node.connect(self.addresses[0], timeout=TIMEOUT)
> 34: File
> "/home/travis/build/apache/qpid-dispatch/python/qpid_dispatch/management/client.py",
> line 128, in connect
> 34: return Node(Node.connection(url, router, timeout, ssl_domain, sasl,
> 34: File
> "/home/travis/build/apache/qpid-dispatch/python/qpid_dispatch/management/client.py",
> line 143, in __init__
> 34: self.client = SyncRequestResponse(connection, self.url.path)
> 34: AttributeError: 'str' object has no attribute 'path'
> 34:
> 34: ======================================================================
> 34: ERROR: test_03_multicast
> (system_tests_two_routers.TwoRouterExtensionStateTest)
> 34: Verify that disposition state set by the publisher is available to all
> 34: ----------------------------------------------------------------------
> 34: Traceback (most recent call last):
> 34: File
> "/home/travis/build/apache/qpid-dispatch/tests/system_tests_two_routers.py",
> line 2061, in test_03_multicast
> 34: self.RouterA.wait_address("multicast/thingy", subscribers=3)
> 34: File "/home/travis/build/apache/qpid-dispatch/tests/system_test.py",
> line 672, in wait_address
> 34: assert retry(check, **retry_kwargs)
> 34: File "/home/travis/build/apache/qpid-dispatch/tests/system_test.py",
> line 141, in retry
> 34: ret = function()
> 34: File "/home/travis/build/apache/qpid-dispatch/tests/system_test.py",
> line 662, in check
> 34: addrs = self.management.query(
> 34: File "/home/travis/build/apache/qpid-dispatch/tests/system_test.py",
> line 504, in management
> 34: self._management = Node.connect(self.addresses[0], timeout=TIMEOUT)
> 34: File
> "/home/travis/build/apache/qpid-dispatch/python/qpid_dispatch/management/client.py",
> line 128, in connect
> 34: return Node(Node.connection(url, router, timeout, ssl_domain, sasl,
> 34: File
> "/home/travis/build/apache/qpid-dispatch/python/qpid_dispatch/management/client.py",
> line 143, in __init__
> 34: self.client = SyncRequestResponse(connection, self.url.path)
> 34: AttributeError: 'str' object has no attribute 'path'{noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
