[ 
https://issues.apache.org/jira/browse/QPID-8500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17271164#comment-17271164
 ] 

ASF GitHub Bot commented on QPID-8500:
--------------------------------------

Dedeepya-T commented on a change in pull request #77:
URL: https://github.com/apache/qpid-broker-j/pull/77#discussion_r563539973



##########
File path: 
bdbstore/src/test/java/org/apache/qpid/server/store/berkeleydb/replication/ReplicatedEnvironmentFacadeTest.java
##########
@@ -993,7 +1011,7 @@ public void testNodeRolledback()  throws Exception
         LOGGER.debug("RESTARTING " + replicaName);
         // Restart the node2, making it primary so it becomes master
         TestStateChangeListener node2StateChangeListener = new 
TestStateChangeListener();
-        node2 = addNode(replicaName, replicaNodeHostPort, true, 
node2StateChangeListener, new NoopReplicationGroupListener());
+        node2 = addNode(replicaName, replicaNodeHostPort, true, 
node2StateChangeListener, new NoopReplicationGroupListener(),false);

Review comment:
       Done!

##########
File path: 
bdbstore/src/test/java/org/apache/qpid/server/store/berkeleydb/replication/ReplicatedEnvironmentFacadeTest.java
##########
@@ -967,7 +985,7 @@ public void testNodeRolledback()  throws Exception
         createConfig.setTransactional(true);
 
         TestStateChangeListener masterListener = new TestStateChangeListener();
-        ReplicatedEnvironmentFacade node1 = addNode(TEST_NODE_NAME, 
TEST_NODE_HOST_PORT, true, masterListener, new NoopReplicationGroupListener());
+        ReplicatedEnvironmentFacade node1 = addNode(TEST_NODE_NAME, 
TEST_NODE_HOST_PORT, true, masterListener, new 
NoopReplicationGroupListener(),false);

Review comment:
       Done!

##########
File path: 
bdbstore/src/test/java/org/apache/qpid/server/store/berkeleydb/replication/ReplicatedEnvironmentFacadeTest.java
##########
@@ -945,7 +963,7 @@ public boolean onIntruderNode(ReplicationNode node)
                 return true;
             }
         };
-        ReplicatedEnvironmentFacade firstNode = createMaster(listener);
+        ReplicatedEnvironmentFacade firstNode = createMaster(listener,false);

Review comment:
       Done!

##########
File path: 
bdbstore/src/test/java/org/apache/qpid/server/store/berkeleydb/replication/ReplicatedEnvironmentFacadeTest.java
##########
@@ -921,7 +939,7 @@ public void testPermittedNodeIsAllowedToConnect() throws 
Exception
         permittedNodes.add(node1NodeHostPort);
         firstNode.setPermittedNodes(permittedNodes);
 
-        ReplicatedEnvironmentConfiguration configuration =  
createReplicatedEnvironmentConfiguration(TEST_NODE_NAME + "_1", 
node1NodeHostPort, false);
+        ReplicatedEnvironmentConfiguration configuration =  
createReplicatedEnvironmentConfiguration(TEST_NODE_NAME + "_1", 
node1NodeHostPort, false,false);

Review comment:
       Done!

##########
File path: 
bdbstore/src/test/java/org/apache/qpid/server/store/berkeleydb/replication/ReplicatedEnvironmentFacadeTest.java
##########
@@ -911,7 +929,7 @@ public void testSetPermittedNodes() throws Exception
     @Test
     public void testPermittedNodeIsAllowedToConnect() throws Exception
     {
-        ReplicatedEnvironmentFacade firstNode = createMaster();
+        ReplicatedEnvironmentFacade firstNode = createMaster(false);

Review comment:
       Done!

##########
File path: 
bdbstore/src/test/java/org/apache/qpid/server/store/berkeleydb/replication/ReplicatedEnvironmentFacadeTest.java
##########
@@ -891,7 +909,7 @@ public void testBeginTransaction() throws Exception
     @Test
     public void testSetPermittedNodes() throws Exception
     {
-        ReplicatedEnvironmentFacade firstNode = createMaster();
+        ReplicatedEnvironmentFacade firstNode = createMaster(false);

Review comment:
       Done!

##########
File path: 
bdbstore/src/test/java/org/apache/qpid/server/store/berkeleydb/replication/ReplicatedEnvironmentFacadeTest.java
##########
@@ -868,7 +886,7 @@ public void stateChange(StateChangeEvent event) throws 
RuntimeException
     @Test
     public void testBeginTransaction() throws Exception
     {
-        ReplicatedEnvironmentFacade facade = createMaster();
+        ReplicatedEnvironmentFacade facade = createMaster(false);

Review comment:
       Done!

##########
File path: 
bdbstore/src/test/java/org/apache/qpid/server/store/berkeleydb/replication/ReplicatedEnvironmentFacadeTest.java
##########
@@ -854,7 +872,7 @@ public void stateChange(StateChangeEvent event) throws 
RuntimeException
         };
         String thirdNodeName = TEST_NODE_NAME + "_2";
         ReplicatedEnvironmentFacade thirdNode = addNode(thirdNodeName, 
node2NodeHostPort, TEST_DESIGNATED_PRIMARY,
-                                                        
testStateChangeListener, new NoopReplicationGroupListener());
+                                                        
testStateChangeListener, new NoopReplicationGroupListener(),false);

Review comment:
       Done!




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


> [Broker-J] Introduce a switch to disable coalescing committer in BDB HA 
> message store
> -------------------------------------------------------------------------------------
>
>                 Key: QPID-8500
>                 URL: https://issues.apache.org/jira/browse/QPID-8500
>             Project: Qpid
>          Issue Type: Improvement
>          Components: Broker-J
>            Reporter: Alex Rudyy
>            Priority: Major
>             Fix For: qpid-java-broker-8.0.4
>
>
> A BDB JE replication Feeder fails sporadically with errors like the one below
> {noformat}
> Halted log file reading at file 0x7472c8 offset 0x199d07 
> offset(decimal)=1678599 prev=0x199cd5:
> entry=DEL_LN_TXtype=31,version=14)
> prev=0x199cd5
> size=44
> Next entry should be at 0x199d49
> com.sleepycat.je.EnvironmentFailureException: (JE 7.4.5) want to read 
> 52,431,066,320 but reader at 52,431,066,327 UNEXPECTED_STATE: Unexpected 
> internal state, may have side effects.
>         at 
> com.sleepycat.je.EnvironmentFailureException.unexpectedState(EnvironmentFailureException.java:428)
>         at 
> com.sleepycat.je.rep.stream.FeederReader.checkForPassingTarget(FeederReader.java:297)
>         at 
> com.sleepycat.je.rep.stream.FeederReader.isTargetEntry(FeederReader.java:317)
>         at 
> com.sleepycat.je.log.FileReader.readNextEntryAllowExceptions(FileReader.java:332)
>         at com.sleepycat.je.log.FileReader.readNextEntry(FileReader.java:245)
>         at 
> com.sleepycat.je.rep.stream.FeederReader.scanForwards(FeederReader.java:280)
>         at 
> com.sleepycat.je.rep.stream.MasterFeederSource.getWireRecord(MasterFeederSource.java:70)
>         at 
> com.sleepycat.je.rep.impl.node.Feeder$OutputThread.writeAvailableEntries(Feeder.java:1266)
>         at 
> com.sleepycat.je.rep.impl.node.Feeder$OutputThread.run(Feeder.java:1144)
> {noformat}
> Based on discussion at 
> [https://community.oracle.com/tech/developers/discussion/4300421/master-fails-unexpectedly-due-to-feeder-output-halted-log-file-reading-at-file-0x334f63-offset-0x8ce]
>  we need a way to configure broker without a coalescing committer. The local 
> sync policy would be set as per user virtual host settings.
> A context variable can be added into BDB HA to disable coalescing committer 
> thread.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to