[
https://issues.apache.org/jira/browse/DISPATCH-1922?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17272017#comment-17272017
]
ASF GitHub Bot commented on DISPATCH-1922:
------------------------------------------
jiridanek commented on a change in pull request #996:
URL: https://github.com/apache/qpid-dispatch/pull/996#discussion_r564388542
##########
File path: dockerfiles/Dockerfile-centos7
##########
@@ -36,37 +35,34 @@
################# Begin code #######
-# Get the latest Centos version from dockerhub
-FROM centos:6
+# Get the latest CentOS 7 version from dockerhub
+FROM library/centos:7
MAINTAINER "[email protected]"
-# Install all the required packages. Some in this list were picked off from
proton's INSTALL.md
(https://github.com/apache/qpid-proton/blob/master/INSTALL.md) and the rest are
from dispatch (https://github.com/apache/qpid-dispatch/blob/master/README)
-
# For centos, some packages are found in the epel repo, so first install
access to it
RUN yum -y install epel-release
# now install the rest of the packages
-RUN yum -y install gcc gcc-c++ cmake libuuid-devel openssl-devel
python-unittest2 python-setuptools python-argparse cyrus-sasl-devel
cyrus-sasl-plain cyrus-sasl-gssapi cyrus-sasl-md5 swig python-devel
java-1.8.0-openjdk-devel git make doxygen valgrind emacs libuv libuv-devel
libwebsockets-devel && yum clean all -y
+RUN yum -y install gcc gcc-c++ cmake libuuid-devel openssl-devel
cyrus-sasl-devel cyrus-sasl-plain cyrus-sasl-gssapi cyrus-sasl-md5 swig
python-devel git make doxygen valgrind emacs
Review comment:
Probably should restore
```suggestion
RUN yum -y install gcc gcc-c++ cmake libuuid-devel openssl-devel
cyrus-sasl-devel cyrus-sasl-plain cyrus-sasl-gssapi cyrus-sasl-md5 swig
python-devel git make doxygen valgrind emacs libwebsockets-devel && yum clean
all -y
```
##########
File path: dockerfiles/Dockerfile-centos7
##########
@@ -36,37 +35,34 @@
################# Begin code #######
-# Get the latest Centos version from dockerhub
-FROM centos:6
+# Get the latest CentOS 7 version from dockerhub
+FROM library/centos:7
MAINTAINER "[email protected]"
-# Install all the required packages. Some in this list were picked off from
proton's INSTALL.md
(https://github.com/apache/qpid-proton/blob/master/INSTALL.md) and the rest are
from dispatch (https://github.com/apache/qpid-dispatch/blob/master/README)
-
# For centos, some packages are found in the epel repo, so first install
access to it
RUN yum -y install epel-release
# now install the rest of the packages
-RUN yum -y install gcc gcc-c++ cmake libuuid-devel openssl-devel
python-unittest2 python-setuptools python-argparse cyrus-sasl-devel
cyrus-sasl-plain cyrus-sasl-gssapi cyrus-sasl-md5 swig python-devel
java-1.8.0-openjdk-devel git make doxygen valgrind emacs libuv libuv-devel
libwebsockets-devel && yum clean all -y
+RUN yum -y install gcc gcc-c++ cmake libuuid-devel openssl-devel
cyrus-sasl-devel cyrus-sasl-plain cyrus-sasl-gssapi cyrus-sasl-md5 swig
python-devel git make doxygen valgrind emacs
Review comment:
Probably should restore
```suggestion
RUN yum -y install gcc gcc-c++ cmake libuuid-devel openssl-devel
cyrus-sasl-devel cyrus-sasl-plain cyrus-sasl-gssapi cyrus-sasl-md5 swig
python-devel git make doxygen valgrind emacs libwebsockets-devel && yum clean
all -y
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Remove support for Python 2.6
> -----------------------------
>
> Key: DISPATCH-1922
> URL: https://issues.apache.org/jira/browse/DISPATCH-1922
> Project: Qpid Dispatch
> Issue Type: Improvement
> Components: Documentation, Tools
> Affects Versions: 1.15.0
> Reporter: Jiri Daněk
> Assignee: Jiri Daněk
> Priority: Major
> Fix For: 1.16.0
>
>
> Python 2.6 has been on life support for a long time --- it was present
> because of RHEL 6 which is out of support by the end of previous year. Since
> Python 2.6 is gone from Proton, as of PROTON-2319, now is a good time to
> remove the remaining awkward bits of code that only exist to support Python
> 2.6 in Dispatch.
> Python 2.7 - you're next!
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
