Jiri Daněk created DISPATCH-1938:
------------------------------------

             Summary: Unify .eslintrc settings
                 Key: DISPATCH-1938
                 URL: https://issues.apache.org/jira/browse/DISPATCH-1938
             Project: Qpid Dispatch
          Issue Type: Bug
          Components: Console
    Affects Versions: 1.14.0
            Reporter: Jiri Daněk
             Fix For: 1.15.0


Currently, there are two ESlint config files in the project. There is 
{{console/.eslintrc.json}} and there is eslint section in 
{{console/react/package.json}}. The latter is used in a GitHub CI job, the 
former is not. The former is more strict, actually does not match the codestyle 
of the project, at this point, and uses legacy syntax (e.g. {{"no-console": 
"on"}} does not work nowadays).

The {{.eslintrc.json}}:

{code}
{
  "env": {
    "browser": true,
    "node": true,
    "amd": true,
    "jquery": true
  },
  "extends": ["eslint:recommended", "plugin:patternfly-react/recommended"],
  "parserOptions": {
    "ecmaVersion": 6,
    "sourceType": "module",
    "ecmaFeatures": {
      "jsx": true
    }
  },
  "rules": {
    "indent": [
      "error",
      2
    ],
    "linebreak-style": [
      "error",
      "unix"
    ],
    "semi": [
      "error",
      "always"
    ],
    "no-console": "on",
    "no-debugger": 1
  }
}
{code}

Somebody should do something about it.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to