[
https://issues.apache.org/jira/browse/DISPATCH-1939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17274529#comment-17274529
]
Jiri Daněk commented on DISPATCH-1939:
--------------------------------------
There are more optional dependencies I forgot. Because they come from Proton.
They are Cyrus SASL and OpenSSL. It is possible to build Proton without these.
That means USE_SASL and USE_OPENSSL should be added too.
bq. If I understood correctly, we are not unifying one or more cmake options,
instead we are just introducing a new one.
True, I will rename the Jira.
> Unify CMake options for optional dependencies (-DUSE_X=OFF)
> -----------------------------------------------------------
>
> Key: DISPATCH-1939
> URL: https://issues.apache.org/jira/browse/DISPATCH-1939
> Project: Qpid Dispatch
> Issue Type: Improvement
> Affects Versions: 1.14.0, 1.15.0
> Reporter: Jiri Daněk
> Priority: Major
>
> This pattern is already used for libWebSockets. It is in CMakeLists.txt.
> {noformat}
> CMAKE_DEPENDENT_OPTION(USE_LIBNGHTTP2 "Use libnghttp2 for HTTP/2 support" ON
> "libnghttp2_FOUND" OFF)
> {noformat}
> Users should have a final say whether they want HTTP/2 support or not. If we
> condition this on the {{libnghttp2_FOUND}} directly, they have to uninstall
> the library to build Dispatch without HTTP/2 support. With the new option,
> users can directly say whether they want HTTP/2 support or not.
> The name of the variable could be better, maybe? Something like
> {{QD_USE_LIBNGHTTP2}} or maybe {{QD_ENABLE_HTTP2}}? But then i'd have to
> rename the other one too, and would have to create alias for backwards
> compatibility....
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
