[
https://issues.apache.org/jira/browse/DISPATCH-1939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17275480#comment-17275480
]
ASF GitHub Bot commented on DISPATCH-1939:
------------------------------------------
codecov-io commented on pull request #1008:
URL: https://github.com/apache/qpid-dispatch/pull/1008#issuecomment-770158008
#
[Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/1008?src=pr&el=h1)
Report
> Merging
[#1008](https://codecov.io/gh/apache/qpid-dispatch/pull/1008?src=pr&el=desc)
(39f5891) into
[master](https://codecov.io/gh/apache/qpid-dispatch/commit/0c27fdb9f5016258422f2902f98b27985e31dec9?el=desc)
(0c27fdb) will **increase** coverage by `0.00%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/qpid-dispatch/pull/1008?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1008 +/- ##
=======================================
Coverage 78.95% 78.96%
=======================================
Files 112 112
Lines 28550 28550
=======================================
+ Hits 22542 22544 +2
+ Misses 6008 6006 -2
```
| [Impacted
Files](https://codecov.io/gh/apache/qpid-dispatch/pull/1008?src=pr&el=tree) |
Coverage Δ | |
|---|---|---|
|
[src/router\_core/delivery.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1008/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL2RlbGl2ZXJ5LmM=)
| `92.72% <0.00%> (-0.39%)` | :arrow_down: |
|
[src/server.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1008/diff?src=pr&el=tree#diff-c3JjL3NlcnZlci5j)
| `86.67% <0.00%> (-0.11%)` | :arrow_down: |
|
[src/router\_core/transfer.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1008/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL3RyYW5zZmVyLmM=)
| `92.93% <0.00%> (+1.07%)` | :arrow_up: |
------
[Continue to review full report at
Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/1008?src=pr&el=continue).
> **Legend** - [Click here to learn
more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by
[Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/1008?src=pr&el=footer).
Last update
[b828967...39f5891](https://codecov.io/gh/apache/qpid-dispatch/pull/1008?src=pr&el=lastupdated).
Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Add uniform CMake options for optional dependencies (-DUSE_X=OFF)
> -----------------------------------------------------------------
>
> Key: DISPATCH-1939
> URL: https://issues.apache.org/jira/browse/DISPATCH-1939
> Project: Qpid Dispatch
> Issue Type: Improvement
> Affects Versions: 1.14.0, 1.15.0
> Reporter: Jiri Daněk
> Priority: Major
>
> This pattern is already used for libWebSockets. It is in CMakeLists.txt.
> {noformat}
> CMAKE_DEPENDENT_OPTION(USE_LIBNGHTTP2 "Use libnghttp2 for HTTP/2 support" ON
> "libnghttp2_FOUND" OFF)
> {noformat}
> Users should have a final say whether they want HTTP/2 support or not. If we
> condition this on the {{libnghttp2_FOUND}} directly, they have to uninstall
> the library to build Dispatch without HTTP/2 support. With the new option,
> users can directly say whether they want HTTP/2 support or not.
> The name of the variable could be better, maybe? Something like
> {{QD_USE_LIBNGHTTP2}} or maybe {{QD_ENABLE_HTTP2}}? But then i'd have to
> rename the other one too, and would have to create alias for backwards
> compatibility....
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
