[
https://issues.apache.org/jira/browse/DISPATCH-1586?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17278810#comment-17278810
]
ASF GitHub Bot commented on DISPATCH-1586:
------------------------------------------
jiridanek commented on a change in pull request #696:
URL: https://github.com/apache/qpid-dispatch/pull/696#discussion_r570198833
##########
File path: src/http-libwebsockets.c
##########
@@ -537,7 +650,7 @@ static int callback_metrics(struct lws *wsi, enum
lws_callback_reasons reason,
{
qd_http_server_t *hs = wsi_server(wsi);
stats_t *stats = (stats_t*) user;
- uint8_t buffer[LWS_PRE + 2048];
+ uint8_t buffer[LWS_PRE + 26326];
Review comment:
please explain magic number, consider making it an int constant
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Add allocator stats to the set of exported prometheus metrics
> -------------------------------------------------------------
>
> Key: DISPATCH-1586
> URL: https://issues.apache.org/jira/browse/DISPATCH-1586
> Project: Qpid Dispatch
> Issue Type: Improvement
> Reporter: Gordon Sim
> Priority: Major
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
