[
https://issues.apache.org/jira/browse/DISPATCH-1951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17279161#comment-17279161
]
ASF GitHub Bot commented on DISPATCH-1951:
------------------------------------------
kgiusti commented on pull request #1018:
URL: https://github.com/apache/qpid-dispatch/pull/1018#issuecomment-773596829
> This patch does neaten things up a bit. I would remove the asserts that
appear to be there for testing. Does it fix a test failure/crash?
The assert()s on the delivery refcounts don't fix a bug. They provide a
hint to coverity that the decrefs shouldn't be interpreted as freeing the
delivery (sometimes works), and ensure that the caller fulfills the method's
assumption that an extra reference count is held during the call (more bug
prevention than fix).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> system_tests_http2 failing with router crash
> --------------------------------------------
>
> Key: DISPATCH-1951
> URL: https://issues.apache.org/jira/browse/DISPATCH-1951
> Project: Qpid Dispatch
> Issue Type: Bug
> Components: Tests
> Affects Versions: 1.15.0
> Reporter: Ganesh Murthy
> Assignee: Ken Giusti
> Priority: Major
> Fix For: 1.15.0
>
>
> {noformat}
> 69: ResourceWarning: Enable tracemalloc to get the object allocation
> traceback
> 69: test_get_request (system_tests_http2.Http2TestOneInteriorRouter) ... ok
> 69: test_head_request (system_tests_http2.Http2TestOneInteriorRouter) ... ok
> 69: test_patch_request (system_tests_http2.Http2TestOneInteriorRouter) ... ok
> 69: test_post_request (system_tests_http2.Http2TestOneInteriorRouter) ... ok
> 69: test_put_request (system_tests_http2.Http2TestOneInteriorRouter) ... ok
> 71: Verify credit is replenished by sending > the default credit window ... ok
> 71: test_03_server_reconnect
> (system_tests_http1_adaptor.Http1AdaptorEdge2EdgeTest)
> 71: Verify server reconnect logic. ... ok
> 71: test_04_server_pining_for_the_fjords
> (system_tests_http1_adaptor.Http1AdaptorEdge2EdgeTest)
> 69: test_zzz_http_connector_delete
> (system_tests_http2.Http2TestOneInteriorRouter) ... ok
> 69: test_000_stats (system_tests_http2.Http2TestOneStandaloneRouter) ... ok
> 69: test_404 (system_tests_http2.Http2TestOneStandaloneRouter) ... ok
> 69: test_500 (system_tests_http2.Http2TestOneStandaloneRouter) ... FAIL
> 69: test_delete_request (system_tests_http2.Http2TestOneStandaloneRouter) ...
> FAIL
> 69: test_get_image_jpg (system_tests_http2.Http2TestOneStandaloneRouter) ...
> FAIL
> 69: test_get_image_png (system_tests_http2.Http2TestOneStandaloneRouter) ...
> FAIL
> 69: test_get_request (system_tests_http2.Http2TestOneStandaloneRouter) ...
> FAIL
> 69: test_head_request (system_tests_http2.Http2TestOneStandaloneRouter) ...
> FAIL
> 69: test_patch_request (system_tests_http2.Http2TestOneStandaloneRouter) ...
> FAIL
> 69: test_post_request (system_tests_http2.Http2TestOneStandaloneRouter) ...
> FAIL
> 69: test_put_request (system_tests_http2.Http2TestOneStandaloneRouter) ...
> FAIL
> 69: test_zzz_http_connector_delete
> (system_tests_http2.Http2TestOneStandaloneRouter) ... FAIL
> 69:
> 69: Router QDR output file:
> 69: >>>>
> 69: qdrouterd: ../src/router_core/transfer.c:225:
> qdr_link_process_deliveries: Assertion `(link->undelivered).head' failed.
> 69:
> 69: <<<<
> 69:
> 69: Router QDR command file:
> 69: >>>>
> 69: qdrouterd -c http2-test-router.conf -I
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/python
> 69: pid=4383
> 69:
> 69: <<<< {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
