[
https://issues.apache.org/jira/browse/DISPATCH-1955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17282745#comment-17282745
]
ASF GitHub Bot commented on DISPATCH-1955:
------------------------------------------
ChugR commented on a change in pull request #1026:
URL: https://github.com/apache/qpid-dispatch/pull/1026#discussion_r574116550
##########
File path: src/adaptors/tcp_adaptor.c
##########
@@ -567,7 +567,7 @@ static void handle_connection_event(pn_event_t *e,
qd_server_t *qd_server, void
int read = handle_incoming(conn);
conn->last_in_time = tcp_adaptor->core->uptime_ticks;
conn->bytes_in += read;
- qd_log(log, QD_LOG_DEBUG, "[C%"PRIu64"] PN_RAW_CONNECTION_READ Read %i
bytes", conn->conn_id, read);
+ qd_log(log, QD_LOG_DEBUG, "[C%"PRIu64"] PN_RAW_CONNECTION_READ Read %i
of %"PRIu64" bytes", conn->conn_id, read, conn->bytes_in);
Review comment:
Agreed. Will do.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> TCP adaptor logs could show total bytes and other statistics
> ------------------------------------------------------------
>
> Key: DISPATCH-1955
> URL: https://issues.apache.org/jira/browse/DISPATCH-1955
> Project: Qpid Dispatch
> Issue Type: Improvement
> Reporter: Charles E. Rolke
> Assignee: Charles E. Rolke
> Priority: Major
>
> 1. TCP adaptor tracks bytes in and out. The totals could be logged whenever
> the incremental values are logged.
> {code:java}
> 2021-02-10 16:03:30.028139 -0500 TCP_ADAPTOR (debug) [C2]
> PN_RAW_CONNECTION_READ Read 8192 of 1039574 bytes
> {code}
> 2. When a TCP connection is closed a summary of the connections's management
> statistics could be logged.
> {code:java}
> 2021-02-10 16:03:30.029574 -0500 TCP_ADAPTOR (debug) [C2]
> qdr_del_tcp_connection_CT 0.0.0.0:5201 (1) bytes_in=1048576, bytes_out=0,
> opened_time=3, last_in_time=3, last_out_time=0
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
