[
https://issues.apache.org/jira/browse/DISPATCH-1903?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17287254#comment-17287254
]
ASF GitHub Bot commented on DISPATCH-1903:
------------------------------------------
ganeshmurthy commented on a change in pull request #1025:
URL: https://github.com/apache/qpid-dispatch/pull/1025#discussion_r579362235
##########
File path: src/tempstore-posix.c
##########
@@ -0,0 +1,309 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+#include <stdlib.h>
+#include <unistd.h>
+#include <stdio.h>
+#include <inttypes.h>
+#include <stdbool.h>
+#include <string.h>
+#include <sys/types.h>
+#include <sys/stat.h>
+#include <fcntl.h>
+#include <errno.h>
+#include "qpid/dispatch/ctools.h"
+#include "qpid/dispatch/log.h"
+#include "qpid/dispatch/tempstore.h"
+#include "qpid/dispatch/router_core.h"
+#include "qpid/dispatch/protocol_adaptor.h"
+
+typedef struct qdts_state_t qdts_state_t;
+typedef struct qdts_file_t qdts_file_t;
+
+struct qdts_file_t {
+ DEQ_LINKS(qdts_file_t);
+ char *file_path;
+ int write_count;
+};
+
+DEQ_DECLARE(qdts_file_t, qdts_file_list_t);
+
+#define MAX_TEMPLATE 500
+
+struct qdts_state_t {
+ qdr_core_t *core;
+ qd_log_source_t *log;
+ char *address;
+ bool initialized;
+ bool failed;
+ qdr_subscription_t *subscription;
+ char template[MAX_TEMPLATE];
+ char *path;
+ qdts_file_list_t files;
+};
+
+static qdts_state_t qdts_state;
+
+
+bool qd_temp_is_store_created(void)
+{
+ return qdts_state.initialized;
+}
+
+
+char* qd_temp_get_path(const char* filename)
+{
+ qdts_state_t *state = &qdts_state;
+
+ if (!state->initialized)
+ return false;
+
+ size_t path_len = strlen(state->path) + strlen(filename) + 2;
+ char *full_path = (char*) malloc(path_len);
+ strcpy(full_path, state->path);
+ strcat(full_path, "/");
+ strcat(full_path, filename);
+
+ qdts_file_t *file = DEQ_HEAD(state->files);
+ while (!!file) {
+ if (strcmp(file->file_path, full_path) == 0) {
+ return full_path;
+ }
+ file = DEQ_NEXT(file);
+ }
+
+ free(full_path);
+ return 0;
+}
+
+
+static void qdts_init_storage(qdts_state_t *state)
+{
+ char *temp_dir;
+ char *template = "qdrouterd-filestore.XXXXXX";
+
+ //
+ // If the TMPDIR environment variable is set, use that as the prefix path
for
+ // the temporary directory. Otherwise, use "/tmp".
+ //
+ temp_dir = getenv("TMPDIR");
+ if (!temp_dir)
+ temp_dir = "/tmp";
+
+ if (strlen(temp_dir) + strlen(template) + 2 > MAX_TEMPLATE) {
+ qd_log(state->log, QD_LOG_CRITICAL, "Path from environment variable
TMPDIR is too long - using '/tmp'");
+ temp_dir = "/tmp";
+ }
+
+ strcpy(state->template, temp_dir);
+ strcat(state->template, "/");
+ strcat(state->template, template);
+
+ state->path = mkdtemp(state->template);
+ if (!state->path) {
+ qd_log(state->log, QD_LOG_CRITICAL, "Failed to create temporary
directory: %s (%s)",
+ state->template, strerror(errno));
+ state->failed = true;
+ return;
+ }
+
+ state->initialized = true;
+ qd_log(state->log, QD_LOG_INFO, "Store initialized, path: %s",
state->path);
+}
+
+
+static bool qdts_write_file(qdts_state_t *state, const char *filename, const
char *body, int limit)
+{
+ char *full_path = (char*) malloc(strlen(state->path) + strlen(filename) +
2);
+
+ strcpy(full_path, state->path);
+ strcat(full_path, "/");
+ strcat(full_path, filename);
+
+ qdts_file_t *file = DEQ_HEAD(state->files);
+ while (!!file && strcmp(file->file_path, full_path) != 0) {
+ file = DEQ_NEXT(file);
+ }
+
+ if (!file && DEQ_SIZE(state->files) >= limit && limit != 0) {
+ free(full_path);
+ return false;
+ }
+
+ int fd = open(full_path, O_CREAT | O_TRUNC | O_WRONLY, S_IRUSR | S_IWUSR);
+ if (fd > 0) {
+ ssize_t written = write(fd, body, strlen(body));
+ if (written < 0) {
+ qd_log(state->log, QD_LOG_ERROR, "Failed to write file '%s' (%s)",
full_path, strerror(errno));
+ free(full_path);
+ return true;
+ }
+ close(fd);
+ } else {
+ qd_log(state->log, QD_LOG_ERROR, "Failed to open file '%s' (%s)",
full_path, strerror(errno));
+ free(full_path);
+ return true;
+ }
+
+ if (!!file) {
+ file->write_count++;
+ free(full_path);
+ } else {
+ file = NEW(qdts_file_t);
+ DEQ_ITEM_INIT(file);
+ file->file_path = full_path;
+ file->write_count = 1;
+ DEQ_INSERT_TAIL(state->files, file);
+ }
+
+ qd_log(state->log, QD_LOG_INFO, "Temporary file stored: %s", filename);
+ return true;
+}
+
+
+static uint64_t qdts_on_message(void *context, qd_message_t *msg, int
link_maskbit, int inter_router_cost,
+ uint64_t conn_id, const qd_policy_spec_t
*policy_spec, qdr_error_t **error)
+{
+ qdts_state_t *state = (qdts_state_t*) context;
+
+ if (!!policy_spec && !policy_spec->allowTempFile) {
+ qd_log(state->log, QD_LOG_ERROR, "[C%"PRIu64"] Policy violation - temp
file store not permitted", conn_id);
+ *error = qdr_error(QD_AMQP_COND_UNAUTHORIZED_ACCESS, "File store
access forbidden");
+ return PN_REJECTED;
+ }
+
+ if (state->failed) {
+ *error = qdr_error(QD_AMQP_COND_INTERNAL_ERROR, "File store
initialization failed");
+ return PN_REJECTED;
+ }
+
+ if (qd_message_check_depth(msg, QD_DEPTH_BODY) != QD_MESSAGE_DEPTH_OK) {
+ qd_log(state->log, QD_LOG_ERROR, "Invalid message received");
+ *error = qdr_error(QD_AMQP_COND_DECODE_ERROR, "Parse error in
message");
+ return PN_REJECTED;
+ }
+
+ qd_iterator_t *subject_iter = qd_message_field_iterator(msg,
QD_FIELD_SUBJECT);
+ if (!subject_iter) {
+ qd_log(state->log, QD_LOG_ERROR, "Invalid message received - No
Subject");
+ *error = qdr_error(QD_AMQP_COND_INVALID_FIELD, "Invalid request - no
subject header");
+ return PN_REJECTED;
+ }
+
+ char *filename = (char*) qd_iterator_copy(subject_iter);
+ qd_iterator_free(subject_iter);
+
+ if (!!strchr(filename, '/') || !!strchr(filename, '\\') ||
!!strstr(filename, "..")) {
+ qd_log(state->log, QD_LOG_ERROR, "Invalid message received - File name
with path traversal characters");
+ free(filename);
+ *error = qdr_error(QD_AMQP_COND_INVALID_FIELD, "File name contains
path traversal characters");
Review comment:
Can we please mention in the qdrouter.json that file name containing
path traversal characters are invalid?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Remote upload of certificate files for new TLS configurations
> -------------------------------------------------------------
>
> Key: DISPATCH-1903
> URL: https://issues.apache.org/jira/browse/DISPATCH-1903
> Project: Qpid Dispatch
> Issue Type: New Feature
> Components: Container
> Reporter: Ted Ross
> Assignee: Ted Ross
> Priority: Major
> Fix For: 1.16.0
>
>
> Currently, when using the management protocol to create new SSL-profiles,
> those profiles must access certificate files that are already placed in the
> file system. In other words, in order to create an SSL-profile on a running
> router, files must first be placed on the file system in a location
> accessible by the router. This may be problematic in cases where the router
> is remote from the managing agent, or when containerization limits access to
> the router's underlying file system.
> This new feature allows a managing agent to remotely inject files into a
> running router to be stored in temporary file storage. These files are
> usable in sslProfile management entities (by specifying the files without an
> absolute path). The temporary files are removed from the file system on
> router shutdown.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
