[
https://issues.apache.org/jira/browse/DISPATCH-1974?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17294601#comment-17294601
]
ASF GitHub Bot commented on DISPATCH-1974:
------------------------------------------
ChugR commented on a change in pull request #1058:
URL: https://github.com/apache/qpid-dispatch/pull/1058#discussion_r586522506
##########
File path: tests/system_tests_tcp_adaptor.py
##########
@@ -61,7 +55,7 @@ class TCP_echo_server(object):
DISABLE_SELECTOR_TESTS = False
DISABLE_SELECTOR_REASON = ''
try:
- import selectors
+ import selectors # noqa F401: 'selectors' imported but unused
Review comment:
In order to run these tests the echo server and echo client must be run
as subprocesses. And those programs use selectors. This test can't work without
selectors even though it doesn't use them directly.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Fix and remove ignores in flake8 configuration
> ----------------------------------------------
>
> Key: DISPATCH-1974
> URL: https://issues.apache.org/jira/browse/DISPATCH-1974
> Project: Qpid Dispatch
> Issue Type: Improvement
> Affects Versions: 1.16.0
> Reporter: Jiri Daněk
> Priority: Major
>
> Fixes with autopep8 in DISPATCH-1814 resolved many flake8 warnings. There are
> still warnings left that require human consideration and fixing.
> For example, usage of bare {{except}} in the code.
> This must be fixed manually. Fixed issues should then be removed from the
> tox.ini flake8 ignore section.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
