[
https://issues.apache.org/jira/browse/PROTON-2346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17306555#comment-17306555
]
ASF GitHub Bot commented on PROTON-2346:
----------------------------------------
jiridanek commented on pull request #300:
URL: https://github.com/apache/qpid-proton/pull/300#issuecomment-804369264
I'm adding an explanatory comment (about this being a mere performance
hint). I could try to write benchmark for this. From what I saw, it's supposed
to help when there are short critical sections...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Build failure on musl
> ---------------------
>
> Key: PROTON-2346
> URL: https://issues.apache.org/jira/browse/PROTON-2346
> Project: Qpid Proton
> Issue Type: Bug
> Components: proton-c
> Affects Versions: proton-c-0.33.0
> Environment: Linux
> Reporter: Fabrice Fontaine
> Priority: Major
> Attachments:
> 0001-c-src-proactor-epoll-internal.h-fix-build-on-musl.patch
>
>
> Build with epoll proactor on musl is broken since at least version 0.23.0 and
> https://github.com/apache/qpid-proton/commit/37136940e3077f25ce58c94775f48c66f666f4a8
> because musl does not define PTHREAD_MUTEX_ADAPTIVE_NP resulting in the
> following build failure:
> {code:java}
> In file included from
> /home/giuliobenetti/autobuild/run/instance-0/output-1/build/qpid-proton-0.33.0/c/src/proactor/epoll.c:60:
> /home/giuliobenetti/autobuild/run/instance-0/output-1/build/qpid-proton-0.33.0/c/src/proactor/epoll-internal.h:
> In function 'pmutex_init':
> /home/giuliobenetti/autobuild/run/instance-0/output-1/build/qpid-proton-0.33.0/c/src/proactor/epoll-internal.h:319:36:
> error: 'PTHREAD_MUTEX_ADAPTIVE_NP' undeclared (first use in this function);
> did you mean 'PTHREAD_MUTEX_STALLED'?
> 319 | pthread_mutexattr_settype(&attr, PTHREAD_MUTEX_ADAPTIVE_NP);
> | ^~~~~~~~~~~~~~~~~~~~~~~~~
> | PTHREAD_MUTEX_STALLED{code}
> Fixes:
> -
> http://autobuild.buildroot.org/results/6a901b9ff68b7f52cabf8273d1017025fbd93b0d
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
