[
https://issues.apache.org/jira/browse/DISPATCH-2025?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17313945#comment-17313945
]
ASF GitHub Bot commented on DISPATCH-2025:
------------------------------------------
codecov-io edited a comment on pull request #1090:
URL: https://github.com/apache/qpid-dispatch/pull/1090#issuecomment-808764808
#
[Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/1090?src=pr&el=h1)
Report
> Merging
[#1090](https://codecov.io/gh/apache/qpid-dispatch/pull/1090?src=pr&el=desc)
(49df78f) into
[main](https://codecov.io/gh/apache/qpid-dispatch/commit/f2e205c733558102006ed6dd0a44453c9821c80a?el=desc)
(f2e205c) will **decrease** coverage by `0.04%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/qpid-dispatch/pull/1090?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## main #1090 +/- ##
==========================================
- Coverage 82.29% 82.24% -0.05%
==========================================
Files 111 111
Lines 27540 27536 -4
==========================================
- Hits 22663 22648 -15
- Misses 4877 4888 +11
```
| [Impacted
Files](https://codecov.io/gh/apache/qpid-dispatch/pull/1090?src=pr&el=tree) |
Coverage Δ | |
|---|---|---|
|
[src/adaptors/http1/http1\_adaptor.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1090/diff?src=pr&el=tree#diff-c3JjL2FkYXB0b3JzL2h0dHAxL2h0dHAxX2FkYXB0b3IuYw==)
| `82.84% <0.00%> (-0.65%)` | :arrow_down: |
|
[src/router\_core/transfer.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1090/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL3RyYW5zZmVyLmM=)
| `92.02% <0.00%> (-0.65%)` | :arrow_down: |
|
[src/router\_core/forwarder.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1090/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL2ZvcndhcmRlci5j)
| `92.67% <0.00%> (-0.40%)` | :arrow_down: |
|
[src/adaptors/http1/http1\_server.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1090/diff?src=pr&el=tree#diff-c3JjL2FkYXB0b3JzL2h0dHAxL2h0dHAxX3NlcnZlci5j)
| `84.59% <0.00%> (-0.30%)` | :arrow_down: |
|
[src/adaptors/http1/http1\_codec.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1090/diff?src=pr&el=tree#diff-c3JjL2FkYXB0b3JzL2h0dHAxL2h0dHAxX2NvZGVjLmM=)
| `85.15% <0.00%> (-0.13%)` | :arrow_down: |
|
[src/router\_node.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1090/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9ub2RlLmM=)
| `93.59% <0.00%> (-0.11%)` | :arrow_down: |
|
[src/message.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1090/diff?src=pr&el=tree#diff-c3JjL21lc3NhZ2UuYw==)
| `86.30% <0.00%> (-0.09%)` | :arrow_down: |
|
[include/qpid/dispatch/atomic.h](https://codecov.io/gh/apache/qpid-dispatch/pull/1090/diff?src=pr&el=tree#diff-aW5jbHVkZS9xcGlkL2Rpc3BhdGNoL2F0b21pYy5o)
| `100.00% <0.00%> (+6.25%)` | :arrow_up: |
------
[Continue to review full report at
Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/1090?src=pr&el=continue).
> **Legend** - [Click here to learn
more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by
[Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/1090?src=pr&el=footer).
Last update
[f2e205c...49df78f](https://codecov.io/gh/apache/qpid-dispatch/pull/1090?src=pr&el=lastupdated).
Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Compile using C11 language version
> ----------------------------------
>
> Key: DISPATCH-2025
> URL: https://issues.apache.org/jira/browse/DISPATCH-2025
> Project: Qpid Dispatch
> Issue Type: Improvement
> Affects Versions: 1.16.0
> Reporter: Jiri Daněk
> Priority: Major
>
> All supported platforms of Dispatch can compile using C11 (or gnu11) language
> standard.
> There is a caveat that GCC 4.8.5 claims to support C11 atomics but it
> doesn't. (It does not define {{__STDC_NO_ATOMICS__}} while in fact the
> [{{stdatomic.h}} header is
> missing|https://gcc.gnu.org/bugzilla/show_bug.cgi?id=58016].) Thankfully the
> Dispatch code is able to deal with the situation by using GCC-specific
> features, so it is not a problem.
> I do not see any downsides to requiring C11 for Dispatch compilation.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
