[
https://issues.apache.org/jira/browse/PROTON-2354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17315124#comment-17315124
]
ASF subversion and git services commented on PROTON-2354:
---------------------------------------------------------
Commit 0217dc472986b1290ba92db59a2d5f130bf82f5e in qpid-proton's branch
refs/heads/main from Andrew Stitcher
[ https://gitbox.apache.org/repos/asf?p=qpid-proton.git;h=0217dc4 ]
PROTON-2354: Fix to the new destructors that works with C++03
We do still support C++03 and the previous fix had the wrong exception
specification for pre C++11 destructors:
The base exception (std::runtime_error) is specified to not throw any
exeptions so we need to specify the new destructors the same way.
C++11 defaults to non throwing destructors so omitting the exception
specification works there. However earlier C++ doesn't default like this
and so we need to do this explicitly for C++03. The explicit specification
works fine for C++11 as it doesn't actually change anything there.
> C++ test failures on MacOS due to unexported symbols being hidden
> ------------------------------------------------------------------
>
> Key: PROTON-2354
> URL: https://issues.apache.org/jira/browse/PROTON-2354
> Project: Qpid Proton
> Issue Type: Bug
> Components: proton-c
> Environment: macOSX 10.15
> Reporter: Andrew Stitcher
> Assignee: Andrew Stitcher
> Priority: Major
> Labels: macOS
> Fix For: proton-c-0.34.0
>
>
> Since PROTON-2343 build flags have been consistently applied to all builds.
> This has resulted in the MacOS (clang) build respecting the
> ENABLE_HIDE_UNEXPORTED_SYMBOLS, where it seemingly didn't before.
> This causes build failures like:
> {code}
> % ./cpp/connection_driver_test
> TEST: test_driver_link_id()
> TEST: test_endpoint_close()
> TEST: test_driver_disconnected()
> TEST: test_no_container()
> ERROR test_no_container()
> ../cpp/src/connection_driver_test.cpp:546: No container
> TEST: test_spin_interrupt()
> TEST: test_link_address()
> TEST: test_link_anonymous_dynamic()
> TEST: test_link_capability_filter()
> TEST: test_message()
> TEST: test_message_timeout_succeed()
> TEST: test_message_timeout_fail()
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
