[
https://issues.apache.org/jira/browse/DISPATCH-2029?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17316606#comment-17316606
]
ASF GitHub Bot commented on DISPATCH-2029:
------------------------------------------
kgiusti commented on a change in pull request #1097:
URL: https://github.com/apache/qpid-dispatch/pull/1097#discussion_r609023607
##########
File path: tests/system_tests_http1_base.py
##########
@@ -0,0 +1,1187 @@
+#
Review comment:
Hmmm... I think this file shouldn't be a "system_tests_*" file since it
does not define any TestCases. It defines a set of HTTP/1.x tests that are
shared between the http1_adaptor TestCases and http1_over_tcp TestCases.
Name this fine something like http1_tests.py instead otherwise I think
people will be tempted to add HTTP/1.x TestCases here instead of in the proper
system_tests_*.py files.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> [tcp] Run some of the http1 adaptor tests over tcp
> --------------------------------------------------
>
> Key: DISPATCH-2029
> URL: https://issues.apache.org/jira/browse/DISPATCH-2029
> Project: Qpid Dispatch
> Issue Type: Bug
> Components: Tests
> Reporter: Ganesh Murthy
> Assignee: Ganesh Murthy
> Priority: Major
> Fix For: 1.16.0
>
>
> There are some tests in system_tests_http1_adaptor.py that can also be run
> over the tcp protocol. Create a common class that both these tests can use
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
