[
https://issues.apache.org/jira/browse/DISPATCH-2040?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17320446#comment-17320446
]
ASF GitHub Bot commented on DISPATCH-2040:
------------------------------------------
codecov-io commented on pull request #1115:
URL: https://github.com/apache/qpid-dispatch/pull/1115#issuecomment-818957880
#
[Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/1115?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
Report
> Merging
[#1115](https://codecov.io/gh/apache/qpid-dispatch/pull/1115?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
(6d3221c) into
[main](https://codecov.io/gh/apache/qpid-dispatch/commit/393cb70db18333d13169890c489400b2c6e5027d?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
(393cb70) will **increase** coverage by `0.02%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/qpid-dispatch/pull/1115?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## main #1115 +/- ##
==========================================
+ Coverage 82.25% 82.27% +0.02%
==========================================
Files 111 111
Lines 27537 27537
==========================================
+ Hits 22651 22657 +6
+ Misses 4886 4880 -6
```
| [Impacted
Files](https://codecov.io/gh/apache/qpid-dispatch/pull/1115?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
| Coverage Δ | |
|---|---|---|
|
[src/router\_node.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1115/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9ub2RlLmM=)
| `93.59% <100.00%> (ø)` | |
|
[src/router\_core/forwarder.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1115/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9jb3JlL2ZvcndhcmRlci5j)
| `92.67% <0.00%> (-0.40%)` | :arrow_down: |
|
[src/router\_core/core\_client\_api.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1115/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9jb3JlL2NvcmVfY2xpZW50X2FwaS5j)
| `91.41% <0.00%> (-0.38%)` | :arrow_down: |
|
[src/server.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1115/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL3NlcnZlci5j)
| `86.76% <0.00%> (+0.10%)` | :arrow_up: |
|
[src/adaptors/http1/http1\_codec.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1115/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL2FkYXB0b3JzL2h0dHAxL2h0dHAxX2NvZGVjLmM=)
| `85.28% <0.00%> (+0.12%)` | :arrow_up: |
|
[src/router\_core/connections.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1115/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9jb3JlL2Nvbm5lY3Rpb25zLmM=)
| `88.83% <0.00%> (+0.19%)` | :arrow_up: |
|
[src/adaptors/http1/http1\_server.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1115/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL2FkYXB0b3JzL2h0dHAxL2h0dHAxX3NlcnZlci5j)
| `84.88% <0.00%> (+0.29%)` | :arrow_up: |
|
[src/router\_core/transfer.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1115/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9jb3JlL3RyYW5zZmVyLmM=)
| `92.67% <0.00%> (+0.64%)` | :arrow_up: |
------
[Continue to review full report at
Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/1115?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn
more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by
[Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/1115?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
Last update
[393cb70...6d3221c](https://codecov.io/gh/apache/qpid-dispatch/pull/1115?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
Read the [comment
docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Some details missing on dispositions forwarded by router on transacted
> sessions
> -------------------------------------------------------------------------------
>
> Key: DISPATCH-2040
> URL: https://issues.apache.org/jira/browse/DISPATCH-2040
> Project: Qpid Dispatch
> Issue Type: Bug
> Components: Container
> Affects Versions: 1.15.0
> Reporter: Ganesh Murthy
> Priority: Major
>
> Please look at the attach java file for the client reproducer.
>
> Via a transacted session, the client sends two messages to the router, the
> router forwards the messages to the broker, the broker responds with a
> disposition with state=@transactional-state(52)
> [txn-id=b"d35fe0d3-97b6-11eb-a3e4-0a580a830009", outcome=@accepted(36), the
> router does not forward this information to the client
> Here is the frame trace
> {noformat}
> Wed Apr 7 15:35:05 2021 PROTOCOL (trace) [642]:FRAME: 1 <- @transfer(20)
> [handle=1, delivery-id=1, delivery-tag=b"\x00", message-format=0,
> settled=false, more=false, state=@transactional-state(52)
> [txn-id=b"d35fe0d3-97b6-11eb-a3e4-0a580a830009"]] (167)
> "\x00Sp\xc0\x02\x01A\x00Sr\xc1)\x04\xa3\x0ex-opt-jms-destQ\x00\xa3\x12x-opt-jms-msg-typeQ\x05\x00Ss\xd0\x00\x00\x00[\x00\x00\x00\x0a\xa1/ID:2580456d-98f4-4d85-940f-e0e0a237ef3a:3:1:1-1@\xa1\x14app.biz.finance.test@@@@@@\x83\x00\x00\x01x\xac\xf9\x09\x0d\x00Sw\xa1\x0acoucou-3-1"
> Wed Apr 7 15:35:05 2021 PROTOCOL (trace) [642]:FRAME: 1 <- @transfer(20)
> [handle=1, delivery-id=2, delivery-tag=b"\x01", message-format=0,
> settled=false, more=false, state=@transactional-state(52)
> [txn-id=b"d35fe0d3-97b6-11eb-a3e4-0a580a830009"]] (167)
> "\x00Sp\xc0\x02\x01A\x00Sr\xc1)\x04\xa3\x0ex-opt-jms-destQ\x00\xa3\x12x-opt-jms-msg-typeQ\x05\x00Ss\xd0\x00\x00\x00[\x00\x00\x00\x0a\xa1/ID:2580456d-98f4-4d85-940f-e0e0a237ef3a:3:1:1-2@\xa1\x14app.biz.finance.test@@@@@@\x83\x00\x00\x01x\xac\xf9\x09\x0e\x00Sw\xa1\x0acoucou-3-2"
> Wed Apr 7 15:35:05 2021 PROTOCOL (trace) [3]:FRAME: 0 -> @transfer(20)
> [handle=1, delivery-id=7, delivery-tag=b"\x00", message-format=0,
> state=@transactional-state(52)
> [txn-id=b"d35fe0d3-97b6-11eb-a3e4-0a580a830009"]] (173)
> "\x00Sp\xc0\x02\x01A\x00Sr\xd1\x00\x00\x00,\x00\x00\x00\x04\xa3\x0ex-opt-jms-destQ\x00\xa3\x12x-opt-jms-msg-typeQ\x05\x00Ss\xd0\x00\x00\x00[\x00\x00\x00\x0a\xa1/ID:2580456d-98f4-4d85-940f-e0e0a237ef3a:3:1:1-1@\xa1\x14app.biz.finance.test@@@@@@\x83\x00\x00\x01x\xac\xf9\x09\x0d\x00Sw\xa1\x0acoucou-3-1"
> Wed Apr 7 15:35:05 2021 PROTOCOL (trace) [3]:FRAME: 0 -> @transfer(20)
> [handle=1, delivery-id=8, delivery-tag=b"\x01", message-format=0,
> state=@transactional-state(52)
> [txn-id=b"d35fe0d3-97b6-11eb-a3e4-0a580a830009"]] (173)
> "\x00Sp\xc0\x02\x01A\x00Sr\xd1\x00\x00\x00,\x00\x00\x00\x04\xa3\x0ex-opt-jms-destQ\x00\xa3\x12x-opt-jms-msg-typeQ\x05\x00Ss\xd0\x00\x00\x00[\x00\x00\x00\x0a\xa1/ID:2580456d-98f4-4d85-940f-e0e0a237ef3a:3:1:1-2@\xa1\x14app.biz.finance.test@@@@@@\x83\x00\x00\x01x\xac\xf9\x09\x0e\x00Sw\xa1\x0acoucou-3-2"
> Wed Apr 7 15:35:05 2021 PROTOCOL (trace) [3]:FRAME: 0 <- @disposition(21)
> [role=true, first=7, last=7, settled=true, state=@transactional-state(52)
> [txn-id=b"d35fe0d3-97b6-11eb-a3e4-0a580a830009", outcome=@accepted(36) []]]
> Wed Apr 7 15:35:05 2021 PROTOCOL (trace) [642]:FRAME: 1 -> @disposition(21)
> [role=true, first=1, settled=true]
> Wed Apr 7 15:35:05 2021 PROTOCOL (trace) [3]:FRAME: 0 <- @disposition(21)
> [role=true, first=8, last=8, settled=true, state=@transactional-state(52)
> [txn-id=b"d35fe0d3-97b6-11eb-a3e4-0a580a830009", outcome=@accepted(36) []]]
> Wed Apr 7 15:35:05 2021 PROTOCOL (trace) [642]:FRAME: 1 -> @disposition(21)
> [role=true, first=2, settled=true] {noformat}
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
