[ 
https://issues.apache.org/jira/browse/DISPATCH-2047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17326686#comment-17326686
 ] 

ASF GitHub Bot commented on DISPATCH-2047:
------------------------------------------

kgiusti commented on a change in pull request #1137:
URL: https://github.com/apache/qpid-dispatch/pull/1137#discussion_r617699565



##########
File path: src/router_core/transfer.c
##########
@@ -745,6 +742,9 @@ static void qdr_link_deliver_CT(qdr_core_t *core, 
qdr_action_t *action, bool dis
 
     link->total_deliveries++;
 
+    if (link->link_type == QD_LINK_ENDPOINT)

Review comment:
       Should we also move the check for fallback here as well:
   
   ... ENDPOINT && !dlv_link->fallback)  ???




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


> system_tests_one_router fails in test_43_dropped_presettled_receiver_stops
> --------------------------------------------------------------------------
>
>                 Key: DISPATCH-2047
>                 URL: https://issues.apache.org/jira/browse/DISPATCH-2047
>             Project: Qpid Dispatch
>          Issue Type: Test
>          Components: Tests
>    Affects Versions: 1.15.0
>            Reporter: Ganesh Murthy
>            Assignee: Ganesh Murthy
>            Priority: Major
>             Fix For: 1.16.0
>
>
> {noformat}
> 20: ======================================================================
> 20: FAIL: test_43_dropped_presettled_receiver_stops 
> (system_tests_one_router.OneRouterTest)
> 20: ----------------------------------------------------------------------
> 20: Traceback (most recent call last):
> 20:   File 
> "/home/travis/build/apache/qpid-dispatch/tests/system_tests_one_router.py", 
> line 667, in test_43_dropped_presettled_receiver_stops
> 20:     self.assertEqual(None, test.error)
> 20: AssertionError: None != u'Messages sent to the router is 200, Messages 
> processed by the router is 105' {noformat}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to