[
https://issues.apache.org/jira/browse/DISPATCH-2033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17326946#comment-17326946
]
ASF GitHub Bot commented on DISPATCH-2033:
------------------------------------------
ChugR commented on a change in pull request #1147:
URL: https://github.com/apache/qpid-dispatch/pull/1147#discussion_r617889401
##########
File path: tests/system_tests_qdstat.py
##########
@@ -565,6 +565,7 @@ def setUpClass(cls):
cls.router_2 = cls.tester.qdrouterd('test_router_2', config_2,
wait=True)
cls.router_1 = cls.tester.qdrouterd('test_router_1', config_1,
wait=True)
cls.router_1.wait_router_connected('R2')
+ cls.router_2.wait_router_connected('R1')
Review comment:
That's a surprising fix. If 1 is connected to 2 then how can 2 not be
connected to 1?
Not to say that this is not a fix but maybe it's just the time spent
executing the wait allows for some other thing to stabilize and not that 2 was
not connected to 1.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Rare flaky failure in system_tests_qdstat: out.count('UTC') != 1
> ----------------------------------------------------------------
>
> Key: DISPATCH-2033
> URL: https://issues.apache.org/jira/browse/DISPATCH-2033
> Project: Qpid Dispatch
> Issue Type: Test
> Reporter: Jiri Daněk
> Assignee: Ganesh Murthy
> Priority: Minor
> Fix For: 1.16.0
>
>
> https://travis-ci.com/github/apache/qpid-dispatch/jobs/495411108#L4787
> {noformat}
> 30: ======================================================================
> 30: FAIL: test_links_all_routers (system_tests_qdstat.QdstatLinkPriorityTest)
> 30: ----------------------------------------------------------------------
> 30: Traceback (most recent call last):
> 30: File
> "/home/travis/build/apache/qpid-dispatch/tests/system_tests_qdstat.py", line
> 657, in test_links_all_routers
> 30: self._test_links_all_routers(['--links', '--all-routers'])
> 30: File
> "/home/travis/build/apache/qpid-dispatch/tests/system_tests_qdstat.py", line
> 651, in _test_links_all_routers
> 30: self.assertTrue(out.count('UTC') == 1)
> 30: AssertionError: False is not true
> 30:
> 30: ----------------------------------------------------------------------
> 30: Ran 85 tests in 58.048s
> 30:
> 30: FAILED (failures=1)
> 30/73 Test #30: system_tests_qdstat ...............................***Failed
> 58.16 sec
> {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
