[ 
https://issues.apache.org/jira/browse/PROTON-2379?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrew Stitcher updated PROTON-2379:
------------------------------------
    Description: 
The {{<proton/version.h>}} include file generated by the Proton C build embeds 
the install prefix which is not something that should be exported by one of the 
installed Proton header files. If an installation needs it then installed 
pkgconfig or cmake data should be queried. This was noticed because the python 
bindings package the core Proton C code:

The python packaged prepared during the build embeds the install prefix in the 
file include/proton/version.h file along with the lib versions.

For example, the package created in the GHA CI build has has:
{noformat}
#define PN_INSTALL_PREFIX "/Users/runner/work/qpid-proton/qpid-proton/INSTALL"
{noformat}
in file python-qpid-proton-0.34.0/include/proton/version.h

 

^ Raised as requested [~astitcher]

  was:
The python packaged prepared during the build embeds the install prefix in the 
file include/proton/version.h file along with the lib versions.

For example, the package created in the GHA CI build has has:
{noformat}
#define PN_INSTALL_PREFIX "/Users/runner/work/qpid-proton/qpid-proton/INSTALL"
{noformat}
in file python-qpid-proton-0.34.0/include/proton/version.h

 

^ Raised as requested [~astitcher]


> Installed header file include/proton/version.h has the build include prefix 
> embedded
> ------------------------------------------------------------------------------------
>
>                 Key: PROTON-2379
>                 URL: https://issues.apache.org/jira/browse/PROTON-2379
>             Project: Qpid Proton
>          Issue Type: Bug
>          Components: proton-c
>    Affects Versions: proton-c-0.34.0
>            Reporter: Robbie Gemmell
>            Assignee: Andrew Stitcher
>            Priority: Minor
>
> The {{<proton/version.h>}} include file generated by the Proton C build 
> embeds the install prefix which is not something that should be exported by 
> one of the installed Proton header files. If an installation needs it then 
> installed pkgconfig or cmake data should be queried. This was noticed because 
> the python bindings package the core Proton C code:
> The python packaged prepared during the build embeds the install prefix in 
> the file include/proton/version.h file along with the lib versions.
> For example, the package created in the GHA CI build has has:
> {noformat}
> #define PN_INSTALL_PREFIX "/Users/runner/work/qpid-proton/qpid-proton/INSTALL"
> {noformat}
> in file python-qpid-proton-0.34.0/include/proton/version.h
>  
> ^ Raised as requested [~astitcher]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to