[
https://issues.apache.org/jira/browse/DISPATCH-2110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17342554#comment-17342554
]
ASF GitHub Bot commented on DISPATCH-2110:
------------------------------------------
ganeshmurthy commented on a change in pull request #1207:
URL: https://github.com/apache/qpid-dispatch/pull/1207#discussion_r630158746
##########
File path: tools/qdstat.in
##########
@@ -540,8 +540,12 @@ class BusManager(object):
row.append(PlainNum(node.routerLink))
if self.opts.verbose:
- row.append(get(node, 'protocolVersion'))
- row.append(get(node, 'cost'))
+ row.append(PlainNum(get(node, 'protocolVersion')))
+ cost = get(node, 'cost')
+ if cost:
Review comment:
If the cost is zero or None, the output shows blank string
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Qdstat number display formatting problems - need full audit
> -----------------------------------------------------------
>
> Key: DISPATCH-2110
> URL: https://issues.apache.org/jira/browse/DISPATCH-2110
> Project: Qpid Dispatch
> Issue Type: Bug
> Components: Tools
> Affects Versions: 1.15.0
> Reporter: Charles E. Rolke
> Assignee: Ganesh Murthy
> Priority: Major
> Fix For: 1.17.0
>
>
> Qdstat has had several quick and dirty patch ups to to fix integers that are
> displayed with some type hints: shows 'int32(0)' instead of '0'. See
> DISPATCH-1953 and DISPATCH-2104.
> There are several other issues of the same type remaining. For instance,
> {code:java}
> qdstat -a -v
> {code}
> Shows an {{in-proc}} column with {{u,int,(1)}} instead of a plain '1'.
> This needs to be cleaned up once and for all and not by more piecemeal
> patches.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
