[ 
https://issues.apache.org/jira/browse/PROTON-2377?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17342655#comment-17342655
 ] 

ASF subversion and git services commented on PROTON-2377:
---------------------------------------------------------

Commit ea627e71ef2e6247b5a813a4b21293775ba1b21e in qpid-proton's branch 
refs/heads/main from dreampearl
[ https://gitbox.apache.org/repos/asf?p=qpid-proton.git;h=ea627e7 ]

PROTON-2377: [cpp] Make tag_counter in sender.cpp atomic


> [cpp] tag_counter is not used in a thread safe way in sender.cpp
> ----------------------------------------------------------------
>
>                 Key: PROTON-2377
>                 URL: https://issues.apache.org/jira/browse/PROTON-2377
>             Project: Qpid Proton
>          Issue Type: Bug
>          Components: cpp-binding
>            Reporter: Rakhi Kumari
>            Priority: Major
>
> uint64_t tag_counter = 0 is a global variable, so it might end up giving 
> duplicate ids to different threads.
> We need to ensure that a single sender will not send a message with a 
> duplicate tag. Thread safety is required to guarantee unique tags. 
> Link to the discussion regarding this issue :
> https://github.com/apache/qpid-proton/pull/309#discussion_r615219442



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to