[
https://issues.apache.org/jira/browse/DISPATCH-2113?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17342822#comment-17342822
]
ASF GitHub Bot commented on DISPATCH-2113:
------------------------------------------
ganeshmurthy commented on a change in pull request #1210:
URL: https://github.com/apache/qpid-dispatch/pull/1210#discussion_r630455722
##########
File path: tests/system_tests_protocol_settings.py
##########
@@ -83,8 +84,8 @@ def test_max_sessions(self):
bc = BlockingConnection(self.router.addresses[0])
bc.create_receiver("xxx")
bc.close()
-
- with open('../setUpClass/MaxSessions.log', 'r') as router_log:
+ logfile = os.path.join(self.router.outdir, self.router.logfile)
Review comment:
Not sure how I missed that one. I fixed it. Thanks !!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Remove all relative path references in python system tests
> ----------------------------------------------------------
>
> Key: DISPATCH-2113
> URL: https://issues.apache.org/jira/browse/DISPATCH-2113
> Project: Qpid Dispatch
> Issue Type: Test
> Components: Tests
> Affects Versions: 1.15.0
> Reporter: Ganesh Murthy
> Assignee: Ganesh Murthy
> Priority: Major
> Fix For: 1.17.0
>
>
> Several tests use relative paths to get log files. For example in
> system_tests_protocol_settings.py we have
> {noformat}
> with open('../setUpClass/MaxSessions.log', 'r') as router_log:{noformat}
>
> The above line can be replaced with:
> {noformat}
> logfile = os.path.join(self.router.outdir, self.router.logfile)
> with open(logfile, 'r') as router_log: {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
