[
https://issues.apache.org/jira/browse/DISPATCH-2068?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17346418#comment-17346418
]
ASF GitHub Bot commented on DISPATCH-2068:
------------------------------------------
jiridanek commented on a change in pull request #1219:
URL: https://github.com/apache/qpid-dispatch/pull/1219#discussion_r633835842
##########
File path: src/message.c
##########
@@ -220,11 +229,17 @@ static void print_parsed_field(qd_parsed_field_t
*parsed_field, char **begin, ch
// 64-bit two’s-complement integer representing milliseconds since
the unix epoch
int timestamp_length = 8;
pn_timestamp_t creation_timestamp = 0;
-
- //qd_iterator_t* iter = qd_message_field_iterator(msg, field);
qd_iterator_t *iter = qd_parse_raw(parsed_field);
- while (!qd_iterator_end(iter) && timestamp_length > 0) {
- timestamp_bytes[--timestamp_length] = qd_iterator_octet(iter);
+ if (lil_endian()) {
Review comment:
I'm trying to see if advice from
https://commandcenter.blogspot.com/2012/04/byte-order-fallacy.html?m=1 is
applicable. So far, I think yes. The code given there does not have to ask
about the native byteorder, only about the byteorder used by the network
protocol.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> [s390x] system_tests_log_message_components
> self.assertIn('creation-time="2017-02-22', log[2])
> ----------------------------------------------------------------------------------------------
>
> Key: DISPATCH-2068
> URL: https://issues.apache.org/jira/browse/DISPATCH-2068
> Project: Qpid Dispatch
> Issue Type: Test
> Affects Versions: 1.16.0
> Reporter: Jiri Daněk
> Assignee: Ganesh Murthy
> Priority: Major
> Fix For: 1.17.0
>
>
> https://travis-ci.com/github/apache/qpid-dispatch/jobs/499516080#L5482
> {noformat}
> 40: ======================================================================
> 40: FAIL: test_log_message_all
> (system_tests_log_message_components.RouterMessageLogTestAll)
> 40: ----------------------------------------------------------------------
> 40: Traceback (most recent call last):
> 40: File
> "/home/travis/build/apache/qpid-dispatch/tests/system_tests_log_message_components.py",
> line 98, in test_log_message_all
> 40: self.assertIn('creation-time="2017-02-22', log[2])
> 40: AssertionError: 'creation-time="2017-02-22' not found in '[C2]: Received
> Message{message-id="123455", user-id=b"testuser", to="amqp://0.0.0.0:26575",
> subject="test-subject", reply-to="hello_world", correlation-id=89,
> content-type=:"text/html; charset=utf-8", content-encoding=:"gzip, deflate",
> creation-time="26583746-09-04 19:39:05.088 +0000", group-id="group1",
> group-sequence=0, reply-to-group-id="group0",
> app-properties={"app-property"=[10, 20, 30], "some-other"=:"O_one"}} on link
> \'fb786832-7305-4d36-8b0f-a5c912444705-logMessageTest\' ( -> logMessageTest)'
> 40:
> 40: ----------------------------------------------------------------------
> 40: Ran 3 tests in 0.824s
> 40:
> 40: FAILED (failures=1)
> 40/74 Test #40: system_tests_log_message_components ...............***Failed
> 0.92 sec
> {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
