[
https://issues.apache.org/jira/browse/DISPATCH-1986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17346908#comment-17346908
]
ASF GitHub Bot commented on DISPATCH-1986:
------------------------------------------
kgiusti commented on a change in pull request #1221:
URL: https://github.com/apache/qpid-dispatch/pull/1221#discussion_r634392753
##########
File path: tests/http1_tests.py
##########
@@ -367,6 +366,27 @@ def check_response(self, rsp):
return body
+def wait_server_starting(server_port, client_port, tests, handler_cls=None):
Review comment:
This is a factory method. I would suggest a more "pythonic" approach
would make this a class method of the TestServer class and call it everywhere
we need to instantiate a TestServer.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> [http1] system_tests_http1_adaptor failure due to Address already in use issue
> ------------------------------------------------------------------------------
>
> Key: DISPATCH-1986
> URL: https://issues.apache.org/jira/browse/DISPATCH-1986
> Project: Qpid Dispatch
> Issue Type: Bug
> Components: Protocol Adaptors
> Affects Versions: 1.15.0
> Reporter: Ganesh Murthy
> Assignee: Ken Giusti
> Priority: Major
> Fix For: 1.17.0
>
>
> {noformat}
> 68: test_01_mgmt (system_tests_http1_adaptor.Http1AdaptorManagementTest) ...
> ok
> 68: test_000_stats (system_tests_http1_adaptor.Http1AdaptorOneRouterTest) ...
> ok
> 68: test_001_get (system_tests_http1_adaptor.Http1AdaptorOneRouterTest) ... ok
> 68: test_002_head (system_tests_http1_adaptor.Http1AdaptorOneRouterTest) ...
> ok
> 68: test_003_post (system_tests_http1_adaptor.Http1AdaptorOneRouterTest) ...
> ok
> 68: test_004_put (system_tests_http1_adaptor.Http1AdaptorOneRouterTest) ... ok
> 68: test_005_get_10 (system_tests_http1_adaptor.Http1AdaptorOneRouterTest)
> ... ERROR
> 68: test_006_head_10 (system_tests_http1_adaptor.Http1AdaptorOneRouterTest)
> ... ok
> 68: test_007_post_10 (system_tests_http1_adaptor.Http1AdaptorOneRouterTest)
> ... ok
> 68: test_008_put_10 (system_tests_http1_adaptor.Http1AdaptorOneRouterTest)
> ... ok
> 68:
> 68: Router INT.A debug dump file:
> 68: >>>>
> 68: alloc.c: Items of type 'qd_buffer_t' remain allocated at shutdown: 16
> (SUPPRESSED)
> 68:
> 68: <<<<
> 68: test_01_backpressure_client
> (system_tests_http1_adaptor.Http1AdaptorQ2Standalone) ... ok
> 68: test_02_backpressure_server
> (system_tests_http1_adaptor.Http1AdaptorQ2Standalone) ... ok
> 68:
> 68: ======================================================================
> 68: ERROR: test_02_credit_replenish
> (system_tests_http1_adaptor.Http1AdaptorEdge2EdgeTest)
> 68: ----------------------------------------------------------------------
> 68: Traceback (most recent call last):
> 68: File
> "/home/travis/build/apache/qpid-dispatch/tests/system_tests_http1_adaptor.py",
> line 1238, in test_02_credit_replenish
> 68: tests=TESTS)
> 68: File
> "/home/travis/build/apache/qpid-dispatch/tests/system_tests_http1_adaptor.py",
> line 256, in __init__
> 68: tests)
> 68: File
> "/home/travis/build/apache/qpid-dispatch/tests/system_tests_http1_adaptor.py",
> line 234, in __init__
> 68: HTTPServer.__init__(self, addr, handler_cls)
> 68: File "/usr/lib/python2.7/SocketServer.py", line 417, in __init__
> 68: self.server_bind()
> 68: File "/usr/lib/python2.7/BaseHTTPServer.py", line 108, in server_bind
> 68: SocketServer.TCPServer.server_bind(self)
> 68: File "/usr/lib/python2.7/SocketServer.py", line 431, in server_bind
> 68: self.socket.bind(self.server_address)
> 68: File "/usr/lib/python2.7/socket.py", line 228, in meth
> 68: return getattr(self._sock,name)(*args)
> 68: error: [Errno 98] Address already in use
> 68:
> 68: ======================================================================
> 68: ERROR: test_03_server_reconnect
> (system_tests_http1_adaptor.Http1AdaptorEdge2EdgeTest)
> 68: ----------------------------------------------------------------------
> 68: Traceback (most recent call last):
> 68: File
> "/home/travis/build/apache/qpid-dispatch/tests/system_tests_http1_adaptor.py",
> line 1270, in test_03_server_reconnect
> 68: tests=TESTS)
> 68: File
> "/home/travis/build/apache/qpid-dispatch/tests/system_tests_http1_adaptor.py",
> line 256, in __init__
> 68: tests)
> 68: File
> "/home/travis/build/apache/qpid-dispatch/tests/system_tests_http1_adaptor.py",
> line 234, in __init__
> 68: HTTPServer.__init__(self, addr, handler_cls)
> 68: File "/usr/lib/python2.7/SocketServer.py", line 417, in __init__
> 68: self.server_bind()
> 68: File "/usr/lib/python2.7/BaseHTTPServer.py", line 108, in server_bind
> 68: SocketServer.TCPServer.server_bind(self)
> 68: File "/usr/lib/python2.7/SocketServer.py", line 431, in server_bind
> 68: self.socket.bind(self.server_address)
> 68: File "/usr/lib/python2.7/socket.py", line 228, in meth
> 68: return getattr(self._sock,name)(*args)
> 68: error: [Errno 98] Address already in use
> 68:
> 68: ======================================================================
> 68: ERROR: test_04_server_pining_for_the_fjords
> (system_tests_http1_adaptor.Http1AdaptorEdge2EdgeTest)
> 68: ----------------------------------------------------------------------
> 68: Traceback (most recent call last):
> 68: File
> "/home/travis/build/apache/qpid-dispatch/tests/system_tests_http1_adaptor.py",
> line 1321, in test_04_server_pining_for_the_fjords
> 68: tests=TESTS)
> 68: File
> "/home/travis/build/apache/qpid-dispatch/tests/system_tests_http1_adaptor.py",
> line 256, in __init__
> 68: tests)
> 68: File
> "/home/travis/build/apache/qpid-dispatch/tests/system_tests_http1_adaptor.py",
> line 234, in __init__
> 68: HTTPServer.__init__(self, addr, handler_cls)
> 68: File "/usr/lib/python2.7/SocketServer.py", line 417, in __init__
> 68: self.server_bind()
> 68: File "/usr/lib/python2.7/BaseHTTPServer.py", line 108, in server_bind
> 68: SocketServer.TCPServer.server_bind(self)
> 68: File "/usr/lib/python2.7/SocketServer.py", line 431, in server_bind
> 68: self.socket.bind(self.server_address)
> 68: File "/usr/lib/python2.7/socket.py", line 228, in meth
> 68: return getattr(self._sock,name)(*args)
> 68: error: [Errno 98] Address already in use
> 68:
> 68: ======================================================================
> 68: ERROR: test_05_large_streaming_msg
> (system_tests_http1_adaptor.Http1AdaptorEdge2EdgeTest)
> 68: ----------------------------------------------------------------------
> 68: Traceback (most recent call last):
> 68: File
> "/home/travis/build/apache/qpid-dispatch/tests/system_tests_http1_adaptor.py",
> line 1428, in test_05_large_streaming_msg
> 68: tests=TESTS_11)
> 68: File
> "/home/travis/build/apache/qpid-dispatch/tests/system_tests_http1_adaptor.py",
> line 256, in __init__
> 68: tests)
> 68: File
> "/home/travis/build/apache/qpid-dispatch/tests/system_tests_http1_adaptor.py",
> line 234, in __init__
> 68: HTTPServer.__init__(self, addr, handler_cls)
> 68: File "/usr/lib/python2.7/SocketServer.py", line 417, in __init__
> 68: self.server_bind()
> 68: File "/usr/lib/python2.7/BaseHTTPServer.py", line 108, in server_bind
> 68: SocketServer.TCPServer.server_bind(self)
> 68: File "/usr/lib/python2.7/SocketServer.py", line 431, in server_bind
> 68: self.socket.bind(self.server_address)
> 68: File "/usr/lib/python2.7/socket.py", line 228, in meth
> 68: return getattr(self._sock,name)(*args)
> 68: error: [Errno 98] Address already in use
> 68:
> 68: ======================================================================
> 68: ERROR: test_005_get_10
> (system_tests_http1_adaptor.Http1AdaptorOneRouterTest)
> 68: ----------------------------------------------------------------------
> 68: Traceback (most recent call last):
> 68: File
> "/home/travis/build/apache/qpid-dispatch/tests/system_tests_http1_adaptor.py",
> line 956, in test_005_get_10
> 68: self._do_request(client, self.TESTS_10["GET"])
> 68: File
> "/home/travis/build/apache/qpid-dispatch/tests/system_tests_http1_adaptor.py",
> line 920, in _do_request
> 68: rsp = client.getresponse()
> 68: File "/usr/lib/python2.7/httplib.py", line 1182, in getresponse
> 68: response.begin()
> 68: File "/usr/lib/python2.7/httplib.py", line 467, in begin
> 68: version, status, reason = self._read_status()
> 68: File "/usr/lib/python2.7/httplib.py", line 423, in _read_status
> 68: line = self.fp.readline(_MAXLINE + 1)
> 68: File "/usr/lib/python2.7/socket.py", line 480, in readline
> 68: data = self._sock.recv(self._rbufsize)
> 68: timeout: timed out
> 68:
> 68: ======================================================================
> 68: FAIL: test_01_concurrent_requests
> (system_tests_http1_adaptor.Http1AdaptorEdge2EdgeTest)
> 68: ----------------------------------------------------------------------
> 68: Traceback (most recent call last):
> 68: File
> "/home/travis/build/apache/qpid-dispatch/tests/system_tests_http1_adaptor.py",
> line 1206, in test_01_concurrent_requests
> 68: self.assertEqual(repeat_ct * REQ_CT, client.count)
> 68: AssertionError: 30 != 25 {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
