[
https://issues.apache.org/jira/browse/PROTON-2299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17346977#comment-17346977
]
ASF GitHub Bot commented on PROTON-2299:
----------------------------------------
tabish121 commented on a change in pull request #40:
URL: https://github.com/apache/qpid-proton-j/pull/40#discussion_r634466429
##########
File path: proton-j/src/main/java/org/apache/qpid/proton/message/Message.java
##########
@@ -210,4 +213,55 @@ public static Message create(Header header,
void clear();
MessageError getError();
+
+ /**
+ * @return the total number of body {@link Section} elements contained in
this {@link Message}
+ */
+ int getBodySectionCount();
+
+ /**
+ * Sets the body {@link Section} instances to use when encoding this
message. The value
+ * given replaces any existing section(s) assigned to this message through
the {@link Message#setBody(Object)}
+ * or {@link #addBodySection(Section)} methods. Calling this method with
a null
+ * or empty collection is equivalent to calling the {@link #clear()}
method.
+ *
+ * @param sections
+ * The {@link Collection} of {@link Section} instance to assign this
message.
+ *
+ * @return this {@link Message} instance.
+ */
+ Message setBodySections(Collection<Section> sections);
Review comment:
I didn't intend to add that level of validation to the existing version
of Message.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Support multiple data sections in amqpMessage
> ---------------------------------------------
>
> Key: PROTON-2299
> URL: https://issues.apache.org/jira/browse/PROTON-2299
> Project: Qpid Proton
> Issue Type: Improvement
> Components: proton-j
> Affects Versions: proton-j-0.33.7
> Reporter: Hemant Tanwar
> Priority: Minor
> Labels: feature-request, qpid
>
>
> This is a request for new feature to provide implementation to support
> multiple Data sections.
> Current usage of single Data section looks like this
> Message amqpMessage = Proton.message();
> amqpMessage.setBody(new Data(new Binary(“my data”.getBytes())));
> This does not allow to add multiple Data sections.
> The AMQP specification require to support "one or more data sections, one or
> more amqp-sequence sections. Specification "
> [http://docs.oasis-open.org/amqp/core/v1.0/os/amqp-core-messaging-v1.0-os.html#section-message-format]
> I have looked into various threads which suggest users of qpid to implement
> their own version of MessageImpl/ Encoders and decoders to achieve this
> functionality.
> Here are previous discussions.
> Previous pull request by community:
> [https://github.com/apache/qpid-proton/pull/54]
> Discussion on developer forum
> [http://qpid.2158936.n2.nabble.com/Re-Amqp-Spec-multiple-byte-is-not-supported-for-DATA-td7695225.html]
> This will duplicate effort by many users of qpid, for a feature which is in
> AMQP specification.
> Can we request this feature to be supported in qpid by providing an
> implementation for it ?
> The API for this could be designed to what make sense, here is one suggestion
> Message amqpMessage = Proton.message();
> amqpMessage.setMultipleBody(Iterable<Section> multipleData);
> or
> amqpMessage.setMultipleBody(List<Section> multipleData);
> And for getting multiple sections ..
> Iterable<Section> amqpMessage.getMultipleBody();
> or
> List<Section> amqpMessage.getMultipleBody();
> Or provide a different implementation of MessageImpl which support this
> feature.
> This feature will help community a lot, so they do not have to maintain on
> the wire amqp protocol details in their code base. For example implementing
> encoders and decoders.
> Since it is being asked few times, it is something community would benefits
> from, more ever it is part of AMQP spec.
> If there is an appetite for this feature, I or any community members provide
> PR for the implementation and finally it becomes part of proton-j library.
>
> Appreciate your response.
> Thank,
> Hemant
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
