[
https://issues.apache.org/jira/browse/DISPATCH-2120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17349332#comment-17349332
]
ASF GitHub Bot commented on DISPATCH-2120:
------------------------------------------
codecov-commenter edited a comment on pull request #1231:
URL: https://github.com/apache/qpid-dispatch/pull/1231#issuecomment-845525612
#
[Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/1231?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
Report
> Merging
[#1231](https://codecov.io/gh/apache/qpid-dispatch/pull/1231?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
(f156b65) into
[main](https://codecov.io/gh/apache/qpid-dispatch/commit/1b80ecbd2339110533f6e5959e34fbe95877aa43?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
(1b80ecb) will **decrease** coverage by `0.04%`.
> The diff coverage is `100.00%`.
> :exclamation: Current head f156b65 differs from pull request most recent
head ba553b1. Consider uploading reports for the commit ba553b1 to get more
accurate results
[](https://codecov.io/gh/apache/qpid-dispatch/pull/1231?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## main #1231 +/- ##
==========================================
- Coverage 84.72% 84.67% -0.05%
==========================================
Files 113 113
Lines 28009 28004 -5
==========================================
- Hits 23731 23713 -18
- Misses 4278 4291 +13
```
| [Impacted
Files](https://codecov.io/gh/apache/qpid-dispatch/pull/1231?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
| Coverage Δ | |
|---|---|---|
|
[src/message.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1231/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL21lc3NhZ2UuYw==)
| `87.20% <100.00%> (-0.06%)` | :arrow_down: |
|
[src/router\_core/connections.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1231/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9jb3JlL2Nvbm5lY3Rpb25zLmM=)
| `90.64% <100.00%> (-0.18%)` | :arrow_down: |
|
[src/iterator.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1231/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL2l0ZXJhdG9yLmM=)
| `89.46% <0.00%> (-3.71%)` | :arrow_down: |
|
[src/adaptors/http1/http1\_server.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1231/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL2FkYXB0b3JzL2h0dHAxL2h0dHAxX3NlcnZlci5j)
| `84.57% <0.00%> (-0.30%)` | :arrow_down: |
|
[src/router\_node.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1231/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9ub2RlLmM=)
| `93.57% <0.00%> (+0.09%)` | :arrow_up: |
|
[src/adaptors/http1/http1\_codec.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1231/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL2FkYXB0b3JzL2h0dHAxL2h0dHAxX2NvZGVjLmM=)
| `85.15% <0.00%> (+0.12%)` | :arrow_up: |
|
[src/router\_core/router\_core.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1231/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9jb3JlL3JvdXRlcl9jb3JlLmM=)
| `87.39% <0.00%> (+0.16%)` | :arrow_up: |
|
[src/adaptors/tcp\_adaptor.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1231/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL2FkYXB0b3JzL3RjcF9hZGFwdG9yLmM=)
| `75.26% <0.00%> (+0.23%)` | :arrow_up: |
|
[src/router\_core/delivery.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1231/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9jb3JlL2RlbGl2ZXJ5LmM=)
| `93.88% <0.00%> (+0.55%)` | :arrow_up: |
| ... and [1
more](https://codecov.io/gh/apache/qpid-dispatch/pull/1231/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
| |
------
[Continue to review full report at
Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/1231?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn
more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by
[Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/1231?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
Last update
[ac8b1ce...ba553b1](https://codecov.io/gh/apache/qpid-dispatch/pull/1231?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
Read the [comment
docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Create GitHub Actions jobs used for gating incoming pull requests
> -----------------------------------------------------------------
>
> Key: DISPATCH-2120
> URL: https://issues.apache.org/jira/browse/DISPATCH-2120
> Project: Qpid Dispatch
> Issue Type: Task
> Environment: Create the following GitHub Actions jobs to validate
> incoming Pull Requests
> * rat check
> * Docs
> * Console Test
> * Console ESLint
> * CentOS 7 docker, gcc, RelWithDebInfo, Latest stable proton
> * Ubuntu 20.04, gcc, RelWithDebInfo, ASAN, Latest stable proton
> * Ubuntu 20.04, gcc, RelWithDebInfo, TSAN, Latest stable proton
> Contrary to previous discussions, I don't want to run Debug builds with ASAN
> (it is slow and compiler is not at its best when it does not have any -O
> turned on). Instead, it is possible to enable asserts even in nondebug
> builds, so I propose doing that.
> This should allow checking in the PRs quickly, without having to wait for
> Travis.
> Reporter: Jiri Daněk
> Assignee: Jiri Daněk
> Priority: Major
> Fix For: 1.17.0
>
>
> Create the following GitHub Actions jobs to validate incoming Pull Requests
> * rat check
> * Docs
> * Console Test
> * Console ESLint
> * CentOS 7 docker, gcc, RelWithDebInfo, Latest stable proton
> * Ubuntu 20.04, gcc, RelWithDebInfo, ASAN, Latest stable proton
> * Ubuntu 20.04, gcc, RelWithDebInfo, TSAN, Latest stable proton
> Contrary to previous discussions, I don't want to run Debug builds with ASAN
> (it is slow and compiler is not at its best when it does not have any -O
> turned on). Instead, it is possible to enable asserts even in nondebug
> builds, so I propose doing that.
> This should allow checking in the PRs quickly, without having to wait for
> Travis.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
