[
https://issues.apache.org/jira/browse/DISPATCH-2169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17361184#comment-17361184
]
ASF GitHub Bot commented on DISPATCH-2169:
------------------------------------------
codecov-commenter commented on pull request #1256:
URL: https://github.com/apache/qpid-dispatch/pull/1256#issuecomment-858927711
#
[Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/1256?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
Report
> Merging
[#1256](https://codecov.io/gh/apache/qpid-dispatch/pull/1256?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
(83ab279) into
[main](https://codecov.io/gh/apache/qpid-dispatch/commit/0c2a5d9c2b0e6b716912101465cb661590d433b6?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
(0c2a5d9) will **decrease** coverage by `0.03%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/qpid-dispatch/pull/1256?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## main #1256 +/- ##
==========================================
- Coverage 84.66% 84.63% -0.04%
==========================================
Files 113 113
Lines 28059 28057 -2
==========================================
- Hits 23756 23745 -11
- Misses 4303 4312 +9
```
| [Impacted
Files](https://codecov.io/gh/apache/qpid-dispatch/pull/1256?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
| Coverage Δ | |
|---|---|---|
|
[...router\_core/modules/edge\_router/link\_route\_proxy.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1256/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9jb3JlL21vZHVsZXMvZWRnZV9yb3V0ZXIvbGlua19yb3V0ZV9wcm94eS5j)
| `78.69% <0.00%> (-4.15%)` | :arrow_down: |
|
[src/router\_core/modules/edge\_router/edge\_mgmt.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1256/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9jb3JlL21vZHVsZXMvZWRnZV9yb3V0ZXIvZWRnZV9tZ210LmM=)
| `84.15% <0.00%> (-1.00%)` | :arrow_down: |
|
[src/router\_core/connections.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1256/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9jb3JlL2Nvbm5lY3Rpb25zLmM=)
| `89.85% <0.00%> (-0.89%)` | :arrow_down: |
|
[src/router\_core/transfer.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1256/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9jb3JlL3RyYW5zZmVyLmM=)
| `93.10% <0.00%> (-0.65%)` | :arrow_down: |
|
[src/router\_core/forwarder.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1256/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9jb3JlL2ZvcndhcmRlci5j)
| `92.64% <0.00%> (-0.40%)` | :arrow_down: |
|
[src/iterator.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1256/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL2l0ZXJhdG9yLmM=)
| `89.46% <0.00%> (+0.16%)` | :arrow_up: |
|
[src/router\_node.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1256/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9ub2RlLmM=)
| `93.66% <0.00%> (+0.19%)` | :arrow_up: |
|
[src/router\_core/delivery.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1256/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9jb3JlL2RlbGl2ZXJ5LmM=)
| `94.07% <0.00%> (+0.74%)` | :arrow_up: |
|
[src/router\_core/router\_core.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1256/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9jb3JlL3JvdXRlcl9jb3JlLmM=)
| `87.04% <0.00%> (+0.96%)` | :arrow_up: |
------
[Continue to review full report at
Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/1256?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn
more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by
[Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/1256?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
Last update
[0c2a5d9...83ab279](https://codecov.io/gh/apache/qpid-dispatch/pull/1256?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
Read the [comment
docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> [http2] data race is http2 adaptor in qdr_http_activate
> -------------------------------------------------------
>
> Key: DISPATCH-2169
> URL: https://issues.apache.org/jira/browse/DISPATCH-2169
> Project: Qpid Dispatch
> Issue Type: Test
> Components: Protocol Adaptors
> Affects Versions: 1.16.0
> Reporter: Ganesh Murthy
> Assignee: Ganesh Murthy
> Priority: Major
>
> {noformat}
> 69: WARNING: ThreadSanitizer: data race (pid=14763)
> 69: Read of size 8 at 0x7b4800005ea0 by thread T1 (mutexes: write M239):
> 69: #0 qdr_http_activate
> /home/travis/build/apache/qpid-dispatch/src/adaptors/http2/http2_adaptor.c:1632
> (libqpid-dispatch.so+0xf6007)
> 69: #1 qdr_activate_connections_CT
> /home/travis/build/apache/qpid-dispatch/src/router_core/router_core_thread.c:89
> (libqpid-dispatch.so+0xcab64)
> 69: #2 router_core_thread
> /home/travis/build/apache/qpid-dispatch/src/router_core/router_core_thread.c:247
> (libqpid-dispatch.so+0xcab64)
> 69: #3 _thread_init
> /home/travis/build/apache/qpid-dispatch/src/posix/threading.c:172
> (libqpid-dispatch.so+0x97156)
> 69: #4 <null> <null> (libtsan.so.0+0x2d1af)
> 69:
> 69: Previous write of size 8 at 0x7b4800005ea0 by thread T4:
> 69: #0 http_connector_establish
> /home/travis/build/apache/qpid-dispatch/src/adaptors/http2/http2_adaptor.c:1655
> (libqpid-dispatch.so+0xf69b6)
> 69: #1 egress_conn_timer_handler
> /home/travis/build/apache/qpid-dispatch/src/adaptors/http2/http2_adaptor.c:2314
> (libqpid-dispatch.so+0xf69b6)
> 69: #2 egress_conn_timer_handler
> /home/travis/build/apache/qpid-dispatch/src/adaptors/http2/http2_adaptor.c:2303
> (libqpid-dispatch.so+0xf69b6)
> 69: #3 qd_timer_visit
> /home/travis/build/apache/qpid-dispatch/src/timer.c:317
> (libqpid-dispatch.so+0xf25b2)
> 69: #4 handle /home/travis/build/apache/qpid-dispatch/src/server.c:1006
> (libqpid-dispatch.so+0xed50e)
> 69: #5 thread_run
> /home/travis/build/apache/qpid-dispatch/src/server.c:1121
> (libqpid-dispatch.so+0xf0e67)
> 69: #6 _thread_init
> /home/travis/build/apache/qpid-dispatch/src/posix/threading.c:172
> (libqpid-dispatch.so+0x97156)
> 69: #7 <null> <null> (libtsan.so.0+0x2d1af)
> 69:
> 69: Location is heap block of size 384 at 0x7b4800005e80 allocated by main
> thread:
> 69: #0 posix_memalign <null> (libtsan.so.0+0x3048d)
> 69: #1 qd_alloc
> /home/travis/build/apache/qpid-dispatch/src/alloc_pool.c:396
> (libqpid-dispatch.so+0x61584)
> 69: #2 new_qdr_http2_connection_t
> /home/travis/build/apache/qpid-dispatch/src/adaptors/http2/http2_adaptor.c:52
> (libqpid-dispatch.so+0xf8f25)
> 69: #3 qdr_http_connection_egress
> /home/travis/build/apache/qpid-dispatch/src/adaptors/http2/http2_adaptor.c:2353
> (libqpid-dispatch.so+0x101905)
> 69: #4 qd_http2_configure_connector
> /home/travis/build/apache/qpid-dispatch/src/adaptors/http2/http2_adaptor.c:2632
> (libqpid-dispatch.so+0x102a1c)
> 69: #5 qd_dispatch_configure_http_connector
> /home/travis/build/apache/qpid-dispatch/src/adaptors/http_common.c:172
> (libqpid-dispatch.so+0x4003d)
> 69: #6 <null> <null> (libffi.so.7+0x6ff4)
> 69: #7 main_process
> /home/travis/build/apache/qpid-dispatch/router/src/main.c:97
> (qdrouterd+0x2bb2)
> 69: #8 main /home/travis/build/apache/qpid-dispatch/router/src/main.c:369
> (qdrouterd+0x2882)
> 69:
> 69: Mutex M239 (0x7b1000000940) created at:
> 69: #0 pthread_mutex_init <null> (libtsan.so.0+0x4a636)
> 69: #1 sys_mutex
> /home/travis/build/apache/qpid-dispatch/src/posix/threading.c:43
> (libqpid-dispatch.so+0x971bf)
> 69: #2 qd_server
> /home/travis/build/apache/qpid-dispatch/src/server.c:1358
> (libqpid-dispatch.so+0xef05f)
> 69: #3 qd_dispatch_prepare
> /home/travis/build/apache/qpid-dispatch/src/dispatch.c:333
> (libqpid-dispatch.so+0x77f3a)
> 69: #4 <null> <null> (libffi.so.7+0x6ff4)
> 69: #5 main_process
> /home/travis/build/apache/qpid-dispatch/router/src/main.c:97
> (qdrouterd+0x2bb2)
> 69: #6 main /home/travis/build/apache/qpid-dispatch/router/src/main.c:369
> (qdrouterd+0x2882)
> 69:
> 69: Thread T1 (tid=14765, running) created by main thread at:
> 69: #0 pthread_create <null> (libtsan.so.0+0x5ea99)
> 69: #1 sys_thread
> /home/travis/build/apache/qpid-dispatch/src/posix/threading.c:181
> (libqpid-dispatch.so+0x97712)
> 69: #2 qdr_core
> /home/travis/build/apache/qpid-dispatch/src/router_core/router_core.c:124
> (libqpid-dispatch.so+0xc4e1e)
> 69: #3 qd_router_setup_late
> /home/travis/build/apache/qpid-dispatch/src/router_node.c:2122
> (libqpid-dispatch.so+0xe89ec)
> 69: #4 <null> <null> (libffi.so.7+0x6ff4)
> 69: #5 main_process
> /home/travis/build/apache/qpid-dispatch/router/src/main.c:97
> (qdrouterd+0x2bb2)
> 69: #6 main /home/travis/build/apache/qpid-dispatch/router/src/main.c:369
> (qdrouterd+0x2882)
> 69:
> 69: Thread T4 (tid=14769, running) created by main thread at:
> 69: #0 pthread_create <null> (libtsan.so.0+0x5ea99)
> 69: #1 sys_thread
> /home/travis/build/apache/qpid-dispatch/src/posix/threading.c:181
> (libqpid-dispatch.so+0x97712)
> 69: #2 qd_server_run
> /home/travis/build/apache/qpid-dispatch/src/server.c:1499
> (libqpid-dispatch.so+0xf105a)
> 69: #3 main_process
> /home/travis/build/apache/qpid-dispatch/router/src/main.c:115
> (qdrouterd+0x2c27)
> 69: #4 main /home/travis/build/apache/qpid-dispatch/router/src/main.c:369
> (qdrouterd+0x2882) {noformat}
>
> https://travis-ci.com/github/apache/qpid-dispatch/jobs/512177666#L6443
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
